Merge ~athos-ribeiro/ubuntu-docker-images/+git/postgresql:12-20.04-full-upgrade into ~ubuntu-docker-images/ubuntu-docker-images/+git/postgresql:12-20.04

Proposed by Athos Ribeiro
Status: Merged
Merged at revision: 10d4998c57c4163e989c2e4bbaf46b178570a6dd
Proposed branch: ~athos-ribeiro/ubuntu-docker-images/+git/postgresql:12-20.04-full-upgrade
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/postgresql:12-20.04
Diff against target: 13 lines (+2/-1)
1 file modified
Dockerfile (+2/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Canonical Server Pending
Review via email: mp+414318@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Athos.

There are two issues with the change, but I'm approving this MP because I'm fine with it once the issues get resolved.

On a side note, this whole file needs to be revisited and improved, but that's not something urgent.

Cheers.

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks Sergio. Fixed all the issues.

Just for the records, I edited the file guided by a `git diff 12-20.04..13-21.10` to check for any other oddities. Meaning we will need to remove `ENV DEBIAN_FRONTEND=noninteractive` from other places when refactoring these Dockerfiles.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Tuesday, January 18 2022, Athos Ribeiro wrote:

> Just for the records, I edited the file guided by a `git diff
> 12-20.04..13-21.10` to check for any other oddities. Meaning we will
> need to remove `ENV DEBIAN_FRONTEND=noninteractive` from other places
> when refactoring these Dockerfiles.

Ouch, thanks for catching this, Athos. It must have slipped during
previous reviews. We will certainly need to fix this issue.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index c576d7b..6ca2e31 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -28,7 +28,8 @@ RUN set -eux; \
6 ! grep -q '/usr/share/locale' /etc/dpkg/dpkg.cfg.d/docker; \
7 fi; \
8 apt-get update; \
9- DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends locales tzdata; rm -rf /var/lib/apt/lists/*; \
10+ DEBIAN_FRONTEND=noninteractive apt-get full-upgrade -y; \
11+ DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends locales tzdata; rm -rf /var/lib/apt/lists/*; \
12 localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8
13 ENV LANG en_US.utf8
14

Subscribers

People subscribed via source and target branches