Merge lp:~asomya/nova/dev into lp:~hudson-openstack/nova/trunk
Proposed by
Arvind Somya
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Vish Ishaya | ||||||||
Approved revision: | 1283 | ||||||||
Merged at revision: | 1316 | ||||||||
Proposed branch: | lp:~asomya/nova/dev | ||||||||
Merge into: | lp:~hudson-openstack/nova/trunk | ||||||||
Diff against target: |
255 lines (+113/-18) 5 files modified
Authors (+1/-0) nova/virt/vmwareapi/network_utils.py (+24/-4) nova/virt/vmwareapi/vm_util.py (+25/-7) nova/virt/vmwareapi/vmops.py (+11/-4) tools/esx/guest_tool.py (+52/-3) |
||||||||
To merge this branch: | bzr merge lp:~asomya/nova/dev | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vish Ishaya (community) | Approve | ||
Rick Harris (community) | Approve | ||
Review via email:
|
Description of the change
Bug #796813: vmwareapi does not support distributed vswitch
The extant API assumed a standard switch network for all cases of ESX(i), was not usable when the hypervisor was added to a distributed portgroup on a virtual switch. The VM's would create a new standard switch with the same name as the dv portgroup.
Bug #796834: ESX(i) : Incorrect machine id parameters in vmx for guest_tool.py
-The machine.id string was missing required information for the guest_tool.py script to set networking in the guest VMs.
-Additionally the script crashed on Python > 2.4 due to the implicit gettext translator(_()) used.
-Added support for Ubuntu guest operating systems.
To post a comment you must log in.
Nice work Arvind.
Some small nits:
> 32 + # NOTE: This only works on ESXi if the port binding is
> 33 + # set to ephemeral
> 81 + # NOTE: Only works on ESXi if the portgroup binding is set to
Per HACKING, this should be NOTE(asomya):
> 40 + "get_dynamic_ property" ,network,
PEP-8 Nit: needs a space after the comma:
"get_ dynamic_ property" , network,
There are a few other pep-8 nits in the code, I'd suggest running the pep8 utility on it.
> 178 +def _set_ubuntu_ networking( network_ details= []):
Usually not a good idea to have a kwarg default to a list like that[1].
Better would be:
def _set_ubuntu_ networking( network_ details= None):
network_ details = []
if not network_details:
OR
network_ details = network_details or []
[1] http:// www.deadlyblood yserious. com/2008/ 05/default- argument- blunders/