Merge lp:~asomya/neutron/lp833163 into lp:neutron/diablo

Proposed by Arvind Somya
Status: Merged
Approved by: Salvatore Orlando
Approved revision: 50
Merged at revision: 50
Proposed branch: lp:~asomya/neutron/lp833163
Merge into: lp:neutron/diablo
Diff against target: 54 lines (+18/-17)
1 file modified
setup.py (+18/-17)
To merge this branch: bzr merge lp:~asomya/neutron/lp833163
Reviewer Review Type Date Requested Status
Tyler Smith Approve
Salvatore Orlando Approve
Somik Behera netstack-core Approve
Review via email: mp+72757@code.launchpad.net

Description of the change

Fixes PEP8 errors in setup.py. Bug 833163

To post a comment you must log in.
Revision history for this message
Somik Behera (somikbehera) wrote :

great! all clean.

review: Approve (netstack-core)
Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

setup.py is now clean.
Approving.

review: Approve
Revision history for this message
Tyler Smith (tylesmit) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2011-08-10 19:47:11 +0000
3+++ setup.py 2011-08-24 17:11:23 +0000
4@@ -2,22 +2,23 @@
5 import sys
6 from setuptools import setup, find_packages
7
8+
9 def read(fname):
10 return open(os.path.join(os.path.dirname(__file__), fname)).read()
11-
12-requirements = ['httplib2','eventlet','routes','webob']
13+
14+requirements = ['httplib2', 'eventlet', 'routes', 'webob']
15
16 setup(
17- name = "Quantum",
18- version = "0.1",
19- description = "Layer 2 network as a service for Openstack",
20- long_description = read('README'),
21- url = 'http://launchpad.net/quantum',
22- license = 'Apache',
23- author = 'Netstack',
24- author_email = 'netstack@launchpad.net',
25- packages = find_packages(exclude=['tests']),
26- classifiers = [
27+ name='Quantum',
28+ version='0.1',
29+ description='Layer 2 network as a service for Openstack',
30+ long_description=read('README'),
31+ url='http://launchpad.net/quantum',
32+ license='Apache',
33+ author='Netstack',
34+ author_email='netstack@launchpad.net',
35+ packages=find_packages(exclude=['tests']),
36+ classifiers=[
37 'Development Status :: 4 - Beta',
38 'Environment :: Console',
39 'Intended Audience :: Developers',
40@@ -26,9 +27,9 @@
41 'Operating System :: OS Independent',
42 'Programming Language :: Python',
43 ],
44- namespace_packages = ["quantum"],
45- install_requires = requirements,
46-
47- tests_require = ["nose"],
48- test_suite = "nose.collector",
49+ namespace_packages=["quantum"],
50+ install_requires=requirements,
51+
52+ tests_require=["nose"],
53+ test_suite="nose.collector",
54 )

Subscribers

People subscribed via source and target branches