Merge lp:~asbalderson/jenkins-launchpad-plugin/trigger-fix into lp:jenkins-launchpad-plugin

Proposed by Alexander Balderson on 2019-05-29
Status: Merged
Approved by: Joshua Powers on 2019-05-30
Approved revision: 147
Merged at revision: 147
Proposed branch: lp:~asbalderson/jenkins-launchpad-plugin/trigger-fix
Merge into: lp:jenkins-launchpad-plugin
Diff against target: 12 lines (+1/-1)
1 file modified
jlp/jenkinsutils.py (+1/-1)
To merge this branch: bzr merge lp:~asbalderson/jenkins-launchpad-plugin/trigger-fix
Reviewer Review Type Date Requested Status
Joshua Powers 2019-05-29 Approve on 2019-05-30
Review via email: mp+368097@code.launchpad.net

Commit message

Remove revision arg from autoland no commit message arguments

Revision is not used in any of templates used when autoland
commit message is empty.

To post a comment you must log in.
Joshua Powers (powersj) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jlp/jenkinsutils.py'
2--- jlp/jenkinsutils.py 2019-04-24 17:57:35 +0000
3+++ jlp/jenkinsutils.py 2019-05-29 21:15:11 +0000
4@@ -832,7 +832,7 @@
5 'autolanding for "%s".' % (mp.web_link))
6 template_args = {
7 'result': 'FAILED',
8- 'revision': mp.source_branch.revision_count,
9+ 'revision': None,
10 'build_url': None,
11 'merge_url': mp.web_link
12 }

Subscribers

People subscribed via source and target branches