Merge lp:~asbalderson/jenkins-launchpad-plugin/private-repo into lp:jenkins-launchpad-plugin
Proposed by
Alexander Balderson
Status: | Merged |
---|---|
Merged at revision: | 145 |
Proposed branch: | lp:~asbalderson/jenkins-launchpad-plugin/private-repo |
Merge into: | lp:jenkins-launchpad-plugin |
Diff against target: |
45 lines (+14/-6) 1 file modified
jlp/commands/autoland.py (+14/-6) |
To merge this branch: | bzr merge lp:~asbalderson/jenkins-launchpad-plugin/private-repo |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joshua Powers (community) | Approve | ||
Review via email: mp+364540@code.launchpad.net |
Commit message
Use git+ssh url's for all autoland operations.
When trying to autoland against repo's which are private on launchpad,
the https_url doesnt exist. Use the git+ssh url instead for those
operations. Because the user performing autoland operations has
access to push to the repo, it should also have access to clone as well.
Description of the change
I suspect the reason the https url was used originally was to ensure that the wrong repo couldnt be pushed to, but that's what automation is for. which should ensure we dont accidentally push incorrectly.
To post a comment you must log in.