Merge lp:~asac/lava-dispatcher/drop-redundant-sudo-lamc into lp:lava-dispatcher

[Alexander Sack]

see commit message. the sudo for lamc is redundant; caused some problems here when i ran lava-dispatcher bravely as normal user - with this patch i can use it nicely; at least lamc is fine.

[Andy Doan (doanac)]

I think the thought was that it would be nice to eventually run the dispatcher as a non-root user. And granting sudoer access to l-a-m-c for a given user would allow that to work. However, there are several other places we require root access using a variety of commands.

So I think this is fine. I'd still like to here Michael's thoughts though.

[Michael Hudson-Doyle (mwhudson)]

Andy Doan <email address hidden> writes:

> I think the thought was that it would be nice to eventually run the dispatcher as a non-root user. And granting sudoer access to l-a-m-c for a given user would allow that to work. However, there are several other places we require root access using a variety of commands.
>
> So I think this is fine. I'd still like to here Michael's thoughts though.

Don't really care tbh -- getting to the point where we can run the
dispatcher without root is going to be so much work that one sudo here
or there isn't going to make much difference, so I'm happy for asac to
merge this.

Cheers,
mwh

[Alexander Sack (asac)]

well, as i said. its redundant as linaro-android-media-create already uses sudo where needed ...

the android fast model lava-dispatch works at least quite well here now...

[Alexander Sack (asac)]

please merge thanks.

=== modified file 'lava_dispatcher/client/lmc_utils.py'
--- lava_dispatcher/client/lmc_utils.py	2012-07-22 00:43:26 +0000
+++ lava_dispatcher/client/lmc_utils.py	2012-08-10 10:20:32 +0000
@@ -106,10 +106,10 @@
     _run_linaro_media_create(cmd)
 
 def generate_android_image(device, boot, data, system, ofile, size="2000M"):
-    cmd = ("flock /var/lock/lava-lmc.lck sudo linaro-android-media-create "
+    cmd = ("flock /var/lock/lava-lmc.lck linaro-android-media-create "
            "--dev %s --image_file %s --image_size %s "
            "--boot %s --userdata %s --system %s" %
-            (device, ofile, size, boot, data,system) )
+            (device, ofile, size, boot, data, system) )
     logging.info("Generating android image with: %s" % cmd)
     _run_linaro_media_create(cmd)