Merge lp:~asac/lava-dashboard/display-passes-fail-in-testrun-list into lp:lava-dashboard

[Alexander Sack]

Amateurish merge request trying to display pass/fail stats for each test run in the test run list of a bundle like: http://validation.linaro.org/lava-server/dashboard/streams/anonymous/doanac/bundles/b4888097587d9f8f3815508f1a4015a426e2a0dc/

NOTE: couldn't test or try because I don't have a local setup. all guesswork; please ping on IRC if bogus.

[Michael Hudson-Doyle (mwhudson)]

I like the idea, but unfortunately the performance is rather bad -- the changed page issues one query per test run in the stream, which can be thousands. I know Zygmunt was working on a denormalization patch that would store the sumamry data in the testrun table and allow an efficient version of your changes, but I don't know what happened to that.

[Alexander Sack (asac)]

when is zyga's feature running? Do we have any bundles with thousands of test runs? My take is that we have various views that are superslow, so we can add this unless we have real live example where this is really super slow.

Unfortunately i cannot test anything because I don't know how to set this django app up :/

[Zygmunt Krynicki (zyga)]

I have it locally here but it was not finished (it works but I wanted to reduce the migrations by starting over). I don't have any time to work on this at this time. I agree with mwhudson.

1) Land pagination
2) Land denormalization
3) Tweak this

review: Disapprove

[Alexander Sack (asac)]

can someone please pick this up? I think it's not OK that the intermediate view doesn't show the passes/fails for the individual bundles. I believe what I understand means we need to duplicate template and only make use of it in this case to be sure that this feature does not accidentially slowdown views that iterate on all bundles...

[Michael Hudson-Doyle (mwhudson)]

Ah, so the patch can be merged now. With the current state of the code, it will only affect the 'test runs in bundle' view, not the 'test runs in bundle stream' view -- but it sounds like that's what you want?

[Alexander Sack (asac)]

Can you replace the "test runs in bundle" and "test runs in bundle stream" view with example URLs? If so, I can provide more info.

[Michael Hudson-Doyle (mwhudson)]

Ah sorry.

Not affected by this patch as things stand: http://validation.linaro.org/lava-server/dashboard/streams/anonymous/alf/test-runs/
Affected: http://validation.linaro.org/lava-server/dashboard/streams/anonymous/alf/bundles/c30c6221603a9db7332334592f2a33dc63f0a256/

[Alexander Sack (asac)]

Yeah, thats OK... let's merge it like this.

Wider question for me is whether http://validation.linaro.org/lava-server/dashboard/streams/anonymous/alf/test-runs/ is good for anything. Do we need it or is it rather confusing?

[Michael Hudson-Doyle (mwhudson)]

Alexander Sack <email address hidden> writes:

> Yeah, thats OK... let's merge it like this.

Cool. Doing so.

> Wider question for me is whether http://validation.linaro.org/lava-server/dashboard/streams/anonymous/alf/test-runs/ is good for anything. Do we need it or is it rather confusing?

It's probably not useful indeed.

Cheers,
mwh

=== modified file 'dashboard_app/templates/dashboard_app/_test_run_list_table.html'
--- dashboard_app/templates/dashboard_app/_test_run_list_table.html	2011-09-27 21:22:36 +0000
+++ dashboard_app/templates/dashboard_app/_test_run_list_table.html	2012-01-25 00:49:25 +0000
@@ -4,6 +4,8 @@
     <tr>
       <th>{% trans "Test Run" %}</th>
       <th>{% trans "Test" %}</th>
+      <th>{% trans "Passes" %}</th>
+      <th>{% trans "Fail" %}</th>
       <th>{% trans "Uploaded On" %} </th>
       <th>{% trans "Analyzed On" %}</th>
     </tr>
@@ -13,6 +15,8 @@
     <tr>
       <td><a href="{{ test_run.get_absolute_url }}"><code>{{ test_run.test }} results<code/></a></td>
       <td><a href="{{ test_run.test.get_absolute_url }}">{{ test_run.test }}</a></td>
+      <td>{{ test_run.get_summary_results.pass }}</td>
+      <td>{{ test_run.get_summary_results.fail }}</td>
       <td>{{ test_run.bundle.uploaded_on|date:"Y-m-d H:i:s" }}</td>
       <td>{{ test_run.analyzer_assigned_date|date:"Y-m-d H:i:s" }}</td>
     </tr>