Merge lp:~asac/clutk/prepare-no-gl-includes-in-clutter into lp:clutk

Proposed by Alexander Sack
Status: Rejected
Rejected by: Andrea Cimitan
Proposed branch: lp:~asac/clutk/prepare-no-gl-includes-in-clutter
Merge into: lp:clutk
Diff against target: 27 lines (+6/-0)
2 files modified
clutk/ctk-menu-expandable.c (+3/-0)
clutk/ctk-menu.c (+3/-0)
To merge this branch: bzr merge lp:~asac/clutk/prepare-no-gl-includes-in-clutter
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Needs Information
Review via email: mp+37512@code.launchpad.net

Description of the change

.c files that use GL_ symbols should not rely on those getting included implicitly by an external lib.

This patch fixes ctk-menu.c and ctk-menu-expandable.c for cases where clutter headers don't include GL/gl.h (e.g. linaro work to make clutter frontend api GL flavour agnostic)

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

I don't think we need this anymore, as clutk looks abandoned to me

review: Abstain
Revision history for this message
Andrea Cimitan (cimi) :
review: Needs Information

Unmerged revisions

259. By Alexander Sack

fix missing gl includes; do not rely on GL/gl.h getting included by clutter

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clutk/ctk-menu-expandable.c'
2--- clutk/ctk-menu-expandable.c 2010-09-16 00:12:23 +0000
3+++ clutk/ctk-menu-expandable.c 2010-10-04 20:01:57 +0000
4@@ -41,6 +41,9 @@
5 #if HAVE_CONFIG_H
6 #include <config.h>
7 #endif
8+
9+#include <GL/gl.h>
10+
11 #include "ctk-menu.h"
12 #include "ctk-menu-expandable.h"
13 #include "ctk-menu-seperator.h"
14
15=== modified file 'clutk/ctk-menu.c'
16--- clutk/ctk-menu.c 2010-09-14 20:26:25 +0000
17+++ clutk/ctk-menu.c 2010-10-04 20:01:57 +0000
18@@ -26,6 +26,9 @@
19 #if HAVE_CONFIG_H
20 #include <config.h>
21 #endif
22+
23+#include <GL/gl.h>
24+
25 #include "ctk-menu.h"
26 #include <math.h>
27 #include <glib.h>

Subscribers

People subscribed via source and target branches