Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-private_browsing

Hello,

I'm still looking around to see where QA can help your sprint, I hope you don't mind. First, it's great you wrote the tests along with the code.

The tests are good, but I made a branch with a couple of refactors that I think will make them more readable and maintainable. Please review it:
https://code.launchpad.net/~canonical-platform-qa/webbrowser-app/webbrowser-app-private_browsing-refactor_tests/+merge/258945

I also think that it will be easier and it will give you quicker feedback if some of the tests were written in QML. I tried to add some, but it was hard to put this file under test. That probably means that the file is too big and doing too many things. Maybe something to refactor in the future when time permits.
I'll leave my branch here in case you are interested, even though it is not close to be ready to land:
https://code.launchpad.net/~canonical-platform-qa/webbrowser-app/webbrowser-app-private_browsing-refactor_tests-qml/+merge/258946

I did some manual tests. The functionality seem to be working nicely in the app. I only found two things:
- the address bar sometimes disappears, which I think is what Arthur mentioned in a comment above.
- when I'm in private mode, the application is still logging some URLs, which kind of defeats the purpose. After launching the app and playing for a while in private mode, I got things like this in the terminal:
qml: [JS] (https://abs.twimg.com/c/swift/en/init.a3bbad015f028aa9dd9f4f76ba7a0757eaba22d1.js:477) JQMIGRATE: jQuery.browser is deprecated

I hope this helps. Our idea is to find ways to increase the value you get out of early testing, so if you think I'm slowing you down or making your work harder, by all means please let me know. Honestly :)

pura vida.