Merge lp:~artmello/ubuntu-push/ubuntu-push-remove_notification_list_check into lp:ubuntu-push

[Arthur Mello]

Do not check if application can use Notification list
Always display application notification to Notification List if notifications are enabled for that app

Do not check if application can use Notification list
Always display application notification to Notification List if notifications are enabled for that app

[system-apps-ci-bot (system-apps-ci-bot)]

FAILED: Continuous integration, rev:169
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/18/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1042/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1042
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/939/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/939/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/939/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/18/rebuild

review: Needs Fixing (continuous-integration)

[lp:~artmello/ubuntu-push/ubuntu-push-remove_notification_list_check]

170. By Arthur Mello on 2016-07-27

Remove unused include

[system-apps-ci-bot (system-apps-ci-bot)]

FAILED: Continuous integration, rev:170
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/19/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1043/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1043
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/940/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/940/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/940/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/19/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

170. By Arthur Mello on 2016-07-27

Remove unused include

169. By Arthur Mello on 2016-07-26

Do not check if application can use Notification list
Always display application notification to Notification List if notifications are enabled for that app

=== modified file 'click/cnotificationsettings/cnotificationsettings.go'
--- click/cnotificationsettings/cnotificationsettings.go	2016-07-08 17:05:38 +0000
+++ click/cnotificationsettings/cnotificationsettings.go	2016-07-27 01:08:17 +0000
@@ -33,7 +33,6 @@
 #define USE_SOUNDS_NOTIFICATIONS_KEY "use-sounds-notifications"
 #define USE_VIBRATIONS_NOTIFICATIONS_KEY "use-vibrations-notifications"
 #define USE_BUBBLES_NOTIFICATIONS_KEY "use-bubbles-notifications"
-#define USE_LIST_NOTIFICATIONS_KEY "use-list-notifications"
 
 GSettings* get_settings() {
     // Check if GSettings schema exists
@@ -153,23 +152,6 @@
     g_object_unref(notificationSettings);
     return bubblesNotify;
 }
-
-int can_use_list_notify(const char *pkgname, const char *appname) {
-    GSettings *notificationSettings = NULL;
-    int listNotify = 0;
-
-    notificationSettings = get_settings_for_app(pkgname, appname);
-    if (!notificationSettings) {
-        return -1;
-    }
-
-    if (g_settings_get_boolean(notificationSettings, USE_LIST_NOTIFICATIONS_KEY)) {
-        listNotify = 1;
-    }
-
-    g_object_unref(notificationSettings);
-    return listNotify;
-}
 */
 import "C"
 
@@ -219,12 +201,3 @@
 	defer C.free(unsafe.Pointer(appname))
 	return C.can_use_bubbles_notify(pkgname, appname) != 0
 }
-
-// CanUseListNotify returns true if the application is marked on gsettings to use list notificy
-func CanUseListNotify(app *click.AppId) bool {
-	pkgname := C.CString(app.Package)
-	appname := C.CString(app.Application)
-	defer C.free(unsafe.Pointer(pkgname))
-	defer C.free(unsafe.Pointer(appname))
-	return C.can_use_list_notify(pkgname, appname) != 0
-}

=== modified file 'messaging/messaging.go'
--- messaging/messaging.go	2016-07-08 17:05:38 +0000
+++ messaging/messaging.go	2016-07-27 01:08:17 +0000
@@ -25,7 +25,6 @@
 
 	"launchpad.net/ubuntu-push/bus/notifications"
 	"launchpad.net/ubuntu-push/click"
-	"launchpad.net/ubuntu-push/click/cnotificationsettings"
 	"launchpad.net/ubuntu-push/launch_helper"
 	"launchpad.net/ubuntu-push/logger"
 	"launchpad.net/ubuntu-push/messaging/cmessaging"
@@ -144,18 +143,11 @@
 	return len(nids)
 }
 
-var canUseListNotify = cnotificationsettings.CanUseListNotify
-
 func (mmu *MessagingMenu) Present(app *click.AppId, nid string, notification *launch_helper.Notification) bool {
 	if notification == nil {
 		panic("please check notification is not nil before calling present")
 	}
 
-	if !canUseListNotify(app) {
-		mmu.Log.Debugf("[%s] list notify disabled by user for this app.", nid)
-		return false
-	}
-
 	card := notification.Card
 
 	if card == nil || !card.Persist || card.Summary == "" {