Merge lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_set_date_new_event into lp:ubuntu-calendar-app
Status: | Merged |
---|---|
Approved by: | Renato Araujo Oliveira Filho |
Approved revision: | 801 |
Merged at revision: | 801 |
Proposed branch: | lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_set_date_new_event |
Merge into: | lp:ubuntu-calendar-app |
Diff against target: |
18 lines (+6/-2) 1 file modified
NewEvent.qml (+6/-2) |
To merge this branch: | bzr merge lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_set_date_new_event |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Renato Araujo Oliveira Filho (community) | Approve | ||
Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+289960@code.launchpad.net |
Commit message
Make sure that startDate/endDate is defined before setting date time
Description of the change
Currently we can see this when creating a new event from "New Event" bottom edge: file://
This MR checks if property is undefined before setting it.
Tests necessary:
----------------
1. Make sure that events with same start/end time imported from google will be displayed with correct colors if they are past or future ones;
2. Make sure that events with different start/end time imported from google will be displayed with correct colors if they are past or future ones;
3. Make sure that when editing an existing event the correct start/end time are displayed
4. Make sure that when creating a new event it has the correct start/end time
5. Guarantee that no error is displayed while executing the above
PASSED: Continuous integration, rev:801 /core-apps- jenkins. ubuntu. com/job/ calendar- app-ci/ 801/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/807/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ calendar- app-ci/ 801/rebuild
https:/