Merge lp:~artmello/gallery-app/gallery-app-window_title into lp:gallery-app

Proposed by Arthur Mello
Status: Merged
Merged at revision: 960
Proposed branch: lp:~artmello/gallery-app/gallery-app-window_title
Merge into: lp:gallery-app
Diff against target: 38 lines (+16/-1)
2 files modified
rc/qml/AlbumViewer/AlbumViewer.qml (+2/-0)
rc/qml/MediaViewer/PopupPhotoViewer.qml (+14/-1)
To merge this branch: bzr merge lp:~artmello/gallery-app/gallery-app-window_title
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+217686@code.launchpad.net

Commit message

Change the page title so it does not show the app name.

Description of the change

Change the page title so it does not show the app name.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rc/qml/AlbumViewer/AlbumViewer.qml'
2--- rc/qml/AlbumViewer/AlbumViewer.qml 2014-03-31 13:06:48 +0000
3+++ rc/qml/AlbumViewer/AlbumViewer.qml 2014-04-29 21:11:57 +0000
4@@ -81,6 +81,8 @@
5 // When the user clicks the back button or pages back to the cover.
6 signal quickCloseRequested()
7
8+ title: i18n.tr("Album")
9+
10 Image {
11 anchors.fill: parent
12 source: "../../img/background-paper.png"
13
14=== modified file 'rc/qml/MediaViewer/PopupPhotoViewer.qml'
15--- rc/qml/MediaViewer/PopupPhotoViewer.qml 2013-07-24 19:10:00 +0000
16+++ rc/qml/MediaViewer/PopupPhotoViewer.qml 2014-04-29 21:11:57 +0000
17@@ -49,7 +49,20 @@
18
19 // updating active will automatically set the tools of the toolbar when activating.
20 active: isPoppedUp
21- onActiveChanged: if (active && popupPhotoViewer.header) popupPhotoViewer.header.hide()
22+ onActiveChanged: {
23+ if (active && popupPhotoViewer.header) {
24+ popupPhotoViewer.header.hide();
25+ // FIXME: The hide function of header is not hiding it sometimes.
26+ // The issue started after we changed the page title
27+ popupPhotoViewer.header.visible = false;
28+ }
29+
30+ if (!active && popupPhotoViewer.header && popupPhotoViewer.header.visible == false) {
31+ popupPhotoViewer.header.visible = true;
32+ }
33+ }
34+
35+ title: i18n.tr("Gallery")
36
37 /*!
38 */

Subscribers

People subscribed via source and target branches