Merge lp:~artmello/gallery-app/gallery-app-fix_1378367 into lp:gallery-app

Proposed by Arthur Mello
Status: Merged
Approved by: Ugo Riboni
Approved revision: 1102
Merged at revision: 1105
Proposed branch: lp:~artmello/gallery-app/gallery-app-fix_1378367
Merge into: lp:gallery-app
Diff against target: 29 lines (+5/-3)
2 files modified
rc/qml/AlbumViewer/AlbumViewer.qml (+1/-2)
rc/qml/AlbumsOverview.qml (+4/-1)
To merge this branch: bzr merge lp:~artmello/gallery-app/gallery-app-fix_1378367
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+238211@code.launchpad.net

Commit message

Show header by default on an empty album

Description of the change

Show header by default on an empty album

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

LGTM

review: Approve
1103. By Arthur Mello

Fix code style

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rc/qml/AlbumViewer/AlbumViewer.qml'
2--- rc/qml/AlbumViewer/AlbumViewer.qml 2014-10-07 13:07:34 +0000
3+++ rc/qml/AlbumViewer/AlbumViewer.qml 2014-10-14 16:21:19 +0000
4@@ -188,8 +188,7 @@
5 // Handle add button.
6 if (hit.objectName === "addButton")
7 showMediaSelector();
8-
9- if (!hit.mediaSource) {
10+ else if (!hit.mediaSource) {
11 albumViewer.toggleHeaderVisibility();
12 return;
13 }
14
15=== modified file 'rc/qml/AlbumsOverview.qml'
16--- rc/qml/AlbumsOverview.qml 2014-10-07 19:07:47 +0000
17+++ rc/qml/AlbumsOverview.qml 2014-10-14 16:21:19 +0000
18@@ -174,7 +174,10 @@
19 if (albumViewer.origin) {
20 albumViewer.visible = true;
21 overview.pushPage(albumViewer);
22- header.visible = false;
23+ if (object.containedCount > 0)
24+ header.visible = false;
25+ else
26+ header.visible = true;
27 }
28 else
29 albumViewer.visible = true

Subscribers

People subscribed via source and target branches