Merge lp:~artmello/camera-app/camera-app-mirror_desktop into lp:camera-app

Proposed by Arthur Mello
Status: Merged
Approved by: Bill Filler
Approved revision: 265
Merged at revision: 265
Proposed branch: lp:~artmello/camera-app/camera-app-mirror_desktop
Merge into: lp:camera-app
Diff against target: 18 lines (+8/-0)
1 file modified
camera-app.qml (+8/-0)
To merge this branch: bzr merge lp:~artmello/camera-app/camera-app-mirror_desktop
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+218679@code.launchpad.net

Commit message

Flip the video horizontally if we are on desktop

Description of the change

Flip the video horizontally if we are on desktop

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list: No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes): Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?: Yes
Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/camera-app) on device or emulator? Yes
If you changed the UI, was the change specified/approved by design? No UI changes.
If you changed the packaging (debian), did you subscribe a core-dev to this MP? No packaging changes.

Revision history for this message
Bill Filler (bfiller) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'camera-app.qml'
2--- camera-app.qml 2014-02-10 10:01:22 +0000
3+++ camera-app.qml 2014-05-07 18:45:47 +0000
4@@ -155,6 +155,14 @@
5 - the resolution and aspect ratio of the feed changes depending on the active camera
6 The item is also separated in a component so it can be unit tested.
7 */
8+
9+ transform: Rotation {
10+ origin.x: viewFinder.width / 2
11+ origin.y: viewFinder.height / 2
12+ axis.x: 0; axis.y: 1; axis.z: 0
13+ angle: application.desktopMode ? 180 : 0
14+ }
15+
16 ViewFinderGeometry {
17 id: viewFinderGeometry
18 anchors.centerIn: parent

Subscribers

People subscribed via source and target branches