Merge lp:~arthurborsboom/xpad/xpad-4.2 into lp:xpad

Proposed by Arthur Borsboom
Status: Merged
Approved by: Arthur Borsboom
Approved revision: no longer in the source branch.
Merged at revision: 643
Proposed branch: lp:~arthurborsboom/xpad/xpad-4.2
Merge into: lp:xpad
Diff against target: 35 lines (+6/-6)
2 files modified
po/fr.po (+1/-1)
src/xpad-settings.c (+5/-5)
To merge this branch: bzr merge lp:~arthurborsboom/xpad/xpad-4.2
Reviewer Review Type Date Requested Status
Arthur Borsboom Approve
Review via email: mp+189914@code.launchpad.net

Description of the change

Bug #307669: Theme colour doesn't hold.
Bug #1216388: error in french traduction

To post a comment you must log in.
Revision history for this message
Arthur Borsboom (arthurborsboom) wrote :

After fixing the comment of Sachin to free the memory, and fighting with the merging mechanism, this merge can be executed.

review: Approve
lp:~arthurborsboom/xpad/xpad-4.2 updated
643. By Arthur Borsboom

Bug #307669: Theme colour doesn't hold, Bug #1216388: error in french traduction

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/fr.po'
2--- po/fr.po 2011-11-14 16:42:43 +0000
3+++ po/fr.po 2013-10-08 16:27:48 +0000
4@@ -229,7 +229,7 @@
5
6 #: ../src/xpad-pad-properties.c:161 ../src/xpad-preferences.c:150
7 msgid "Use this font:"
8-msgstr "Utiliser cette poilce de caractère :"
9+msgstr "Utiliser cette police de caractère :"
10
11 #: ../src/xpad-pad-properties.c:162
12 msgid "Use colors from xpad preferences"
13
14=== modified file 'src/xpad-settings.c'
15--- src/xpad-settings.c 2011-11-16 20:16:17 +0000
16+++ src/xpad-settings.c 2013-10-08 16:27:48 +0000
17@@ -748,13 +748,13 @@
18 gdk_color_free (settings->priv->text);
19 settings->priv->text = gdk_color_copy (&text);
20 }
21-
22+
23+ gdk_color_free (settings->priv->back);
24 if (use_back)
25- {
26- gdk_color_free (settings->priv->back);
27 settings->priv->back = gdk_color_copy (&back);
28- }
29-
30+ else
31+ settings->priv->back = NULL;
32+
33 if (settings->priv->fontname &&
34 strcmp (settings->priv->fontname, "NULL") == 0)
35 {

Subscribers

People subscribed via source and target branches