Code review comment for lp:~arthur-she/lava-dashboard/fix-for-bug-1175597

Thanks a lot for your code, Stevan.
I think I might misunderstand your meaning for the "tests".
I'll check the code again...

2013/6/7 Stevan Radaković <email address hidden>

> Hey Arthur,
>
> so instead of all the if/else business, code would look something like
> this (maybe not 100% accurate didn't try it in the codebase:)
>
> kwargs = {
> name: name,
> '{0}__{1}'.format('value', equation): value,
> content_type_id=content_type_id
> }
>
>
> conditions.append(models.Q(id__in=NamedAttribute.objects.filter(**kwargs).values('object_id')))
>
> I may be missing some quotes but you'll figure it out :)
> --
>
> https://code.launchpad.net/~arthur-she/lava-dashboard/fix-for-bug-1175597/+merge/167494
> You are the owner of lp:~arthur-she/lava-dashboard/fix-for-bug-1175597.
>