Code review comment for lp:~arthur-she/lava-dashboard/fix-for-bug-1175597

Revision history for this message
Stevan Radaković (stevanr) wrote :

Exactly like that!

On 06/06/2013 11:07 AM, Arthur She wrote:
> Stevan, do you mean, use
> equation = models.CharField(
> choices=(
> ('lte', '<='),
> ('eq', '=='),
> ('gte', '>=')),
> max_length=3, default='==')
> instead of
> equation = models.CharField(
> choices=(
> ('<=', '<='),
> ('==', '=='),
> ('>=', '>=')),
> max_length=3, default='==')
> in the class TestRunFilterAttribute
>
>
>
>
>
> 2013/6/5 Stevan Radaković <email address hidden>
>
>> One additional comment, we can circumvent the equation map altogether, if
>> the db values for equation field would be defined as 'lte', 'gte'.. to
>> start with. In the frontend we keep the '<=', '>=' of course...
>> --
>>
>> https://code.launchpad.net/~arthur-she/lava-dashboard/fix-for-bug-1175597/+merge/167494
>> You are the owner of lp:~arthur-she/lava-dashboard/fix-for-bug-1175597.
>>

--
Stevan Radaković | LAVA Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

« Back to merge proposal