Merge lp:~arthru/prestashoperpconnect/fix-1199664 into lp:prestashoperpconnect
Proposed by
arthru
Status: | Merged |
---|---|
Merged at revision: | 233 |
Proposed branch: | lp:~arthru/prestashoperpconnect/fix-1199664 |
Merge into: | lp:prestashoperpconnect |
Diff against target: |
32 lines (+16/-0) 1 file modified
prestashoperpconnect/unit/import_synchronizer.py (+16/-0) |
To merge this branch: | bzr merge lp:~arthru/prestashoperpconnect/fix-1199664 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guewen Baconnier @ Camptocamp | code review, no test | Approve | |
Sébastien BEAU - http://www.akretion.com | Pending | ||
Review via email: mp+173894@code.launchpad.net |
To post a comment you must log in.
Hi,
I fear that it was merged a bit too quick.
Say you have products 1-2500, then 4000-4500, with a hole between the 2 ranges.
If you search from 0 to 1000, then 1001 to 2000, etc. and stops until nothing is found, you will miss the last range of products.
I know that's a very hypothetical issue but it could be prevented as of today.
I don't know too much the Prestashop's API but one way would be to ask the greater ID and loop until reached, is it possible? Otherwise, maybe the last call could be an unlimited query (> last imported) but you could run in the same issue...