Merge lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons

[arthru]

This fixes the bug #1334665

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello,

one could wonder if it wouldn't be better to return the value of the _procure_confirm or _procure_orderpoint_confirm above.

But as there are two methods and not just one, we couldn't just favor the return value of just one of the two methods.

Moreover, the return value of these methods is already a meaningless dummy {}.

So overall, I see no simpler better choice that this return True currently.
Therefor I approve the merge proposal.

review: Approve

[arthru (arthru)]

Really love it when the review is longer than the commit ;)

Thanks for your review !

[Pedro Manuel Baeza (pedro.baeza)]

As stated by Raphael, it's the best question.

Regards

review: Approve (code review)

[Pedro Manuel Baeza (pedro.baeza)]

s/question/solution

[Holger Brunn (Therp) (hbrunn)]

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

10220. By Arthur Vuillard <email address hidden> on 2014-06-26

Fix bug lp:1334665

=== modified file 'procurement/schedulers.py'
--- procurement/schedulers.py	2014-03-10 08:54:20 +0000
+++ procurement/schedulers.py	2014-06-26 13:37:41 +0000
@@ -41,6 +41,7 @@
         self._procure_confirm(cr, uid, use_new_cursor=use_new_cursor, context=context)
         self._procure_orderpoint_confirm(cr, uid, automatic=automatic,\
                 use_new_cursor=use_new_cursor, context=context)
+        return True
 
     def _procure_confirm(self, cr, uid, ids=None, use_new_cursor=False, context=None):
         '''