Merge lp:~artem-anufrij/scratch/close-current-document-ctrl-w into lp:~elementary-apps/scratch/scratch
Proposed by
Artem Anufrij
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Fabio Zaramella | ||||
Approved revision: | 1484 | ||||
Merged at revision: | 1484 | ||||
Proposed branch: | lp:~artem-anufrij/scratch/close-current-document-ctrl-w | ||||
Merge into: | lp:~elementary-apps/scratch/scratch | ||||
Diff against target: |
284 lines (+51/-42) 3 files modified
src/MainWindow.vala (+9/-7) src/Widgets/DocumentView.vala (+39/-31) src/Widgets/SourceView.vala (+3/-4) |
||||
To merge this branch: | bzr merge lp:~artem-anufrij/scratch/close-current-document-ctrl-w | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Fabio Zaramella (community) | Approve | ||
Review via email: mp+254653@code.launchpad.net |
Commit message
Close current tab with ctrl+w
Description of the change
Close current tab with ctrl+w
To post a comment you must log in.
Patch would be relatively short if it wouldn't include trailing spaces removal. After finding the code to review I've found and commented a small whitespace issue, other than that, it looks OK code-wise, can't test right now, but if it works, it can be approved.