Merge lp:~artem-anufrij/scratch/Bugfix-1222075 into lp:~elementary-apps/scratch/scratch
Proposed by
Artem Anufrij
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Robert Roth | ||||
Approved revision: | 1405 | ||||
Merged at revision: | 1426 | ||||
Proposed branch: | lp:~artem-anufrij/scratch/Bugfix-1222075 | ||||
Merge into: | lp:~elementary-apps/scratch/scratch | ||||
Diff against target: |
330 lines (+277/-4) 5 files modified
plugins/CMakeLists.txt (+2/-1) plugins/clipboard-history/CMakeLists.txt (+28/-0) plugins/clipboard-history/ClipboardHistory.vala (+230/-0) plugins/clipboard-history/clipboard-history.plugin (+10/-0) src/Widgets/SourceView.vala (+7/-3) |
||||
To merge this branch: | bzr merge lp:~artem-anufrij/scratch/Bugfix-1222075 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Roth (community) | Approve | ||
Review via email: mp+243343@code.launchpad.net |
This proposal supersedes a proposal from 2014-11-12.
Commit message
Implemented clipboard history plugin (lp:1222075)
Description of the change
"Clipboard History" was implemented into Scratch.
"Clipboard History" stores all COPY and CUT actions. System-wide.
Please test it and give me your feedback!
To post a comment you must log in.
On clicking Paste on one of the items from the clipboard history, I get the following in the console :
[_LOG_LEVEL_FATAL 18:44:12.349959] [GLib] g_string_erase: assertion 'pos >= 0' failed
[_LOG_LEVEL_FATAL 18:44:12.350001] Scratch will not function properly.
Other than that, the plugin could be more useful if it would listen for Gtk clipboard changes [1] (currently only text cut/copied from scratch is added)
[1] https:/ /developer. gnome.org/ gtk3/stable/ gtk3-Clipboards .html