Merge lp:~artem-anufrij/scratch/Bugfix-1085718 into lp:~elementary-apps/scratch/scratch

[Artem Anufrij]

Allow to set the position of the terminal via context-menu.

Switching terminal location via context menu.

[Danielle Foré (danrabbit)]

I would prefer not to set a static px limit here. We should change based on the side of the Line Width Guide and also if there are other panes open like the Folder Browser.

review: Needs Fixing (ux)

[Artem Anufrij (artem-anufrij)]

Hey Dan,

I didn't get any feedback on slack.com about this behavior. I use since a week this branch on my system and it's very helpful, although it will be checked the window width in pix, and not line width.

I think we can merge this branch.

What do you think about?

review: Needs Information ((ux))

[Artem Anufrij (artem-anufrij)]

https://bugs.launchpad.net/scratch/+bug/1085718/+attachment/4259339/+files/Scratch%20-%20Terminal%20movement.mp4

[Cody Garver (codygarver)]

The terminal starts too slim, no? http://i.imgur.com/ODxhith.png

[Artem Anufrij (artem-anufrij)]

@Cody:
It's the currently width of the right bar.

[Danielle Foré (danrabbit)]

Yeah that's way too thin. And again, I don't think it's acceptable to hardcode a px size. We need to be smart about what a sane minimum size is for the terminal and also about what space we have available. hardcoding a px size doesn't take into account other plugins or when settings have been changed by the user.

[Artem Anufrij (artem-anufrij)]

Dan, what do you think about a button in the toolbar for manual switching the terminal location?

[Danielle Foré (danrabbit)]

If we can't do it automatically, perhaps a context menu on the Terminal would be a little more subtle.

[Artem Anufrij (artem-anufrij)]

Could you please review the branch...

[lp:~artem-anufrij/scratch/Bugfix-1085718]

1409. By artem-anufrij on 2014-11-24

Change Menu items: Terminal on Right | Terminal on Bottom

[Danielle Foré (danrabbit)]

Saw screenshots on Slack. Looks solid :)

review: Approve (ux)

[Raphael Isemann (teemperor)]

Looks fine to me in terms of functionality and code-style.

review: Approve (functionality, code-style)

=== modified file 'plugins/terminal/terminal.vala'
--- plugins/terminal/terminal.vala	2014-11-10 18:09:21 +0000
+++ plugins/terminal/terminal.vala	2014-11-24 21:01:57 +0000
@@ -26,7 +26,13 @@
 public class Scratch.Plugins.Terminal : Peas.ExtensionBase,  Peas.Activatable {
 
     MainWindow window = null;
+
     Gtk.Notebook? bottombar = null;
+    Gtk.Notebook? contextbar = null;
+    
+    Gtk.RadioMenuItem location_bottom = null;
+    Gtk.RadioMenuItem location_right = null;
+
     Vte.Terminal terminal;
     Gtk.Grid grid;
 
@@ -37,12 +43,13 @@
     }
 
     public void activate () {
+
         plugins = (Scratch.Services.Interface) object;
 
         plugins.hook_window.connect ((w) => {
             if (window != null)
                 return;
-                
+
             window = w;
             window.key_press_event.connect (switch_focus);
         });
@@ -50,38 +57,66 @@
         plugins.hook_notebook_bottom.connect ((n) => {
             if (bottombar == null) {
                 this.bottombar = n;
-                on_hook (this.bottombar);
-            }
-        });
-        if (bottombar != null)
-            on_hook (this.bottombar);
+            }
+            switch_terminal_location ();
+        });
+
+        plugins.hook_notebook_context.connect ((n) => {
+            if (contextbar == null) {
+                this.contextbar = n;
+            }
+        });
+
+        on_hook ();
     }
 
     public void deactivate () {
         if (terminal != null)
             grid.destroy ();
-        if (window != null)
-            window.key_press_event.disconnect (switch_focus);
+
+        window.key_press_event.disconnect (switch_focus);
+    }
+
+    void switch_terminal_location () {
+     
+     	if (bottombar.page_num (grid) == -1 && this.location_bottom.active) {
+
+            contextbar.remove_page (contextbar.page_num (grid));
+            bottombar.append_page (grid, new Gtk.Label (_("Terminal")));
+            debug ("Move Terminal: BOTTOMBAR.");
+            
+        } else if (contextbar.page_num (grid) == -1 && this.location_right.active) {
+
+            bottombar.remove_page (bottombar.page_num (grid));
+            contextbar.append_page (grid, new Gtk.Label (_("Terminal")));
+            debug ("Move Terminal: CONTEXTBAR.");
+
+        }
     }
 
     bool switch_focus (Gdk.EventKey event) {
         if (event.keyval == Gdk.Key.t
             && Gdk.ModifierType.MOD1_MASK in event.state
             && Gdk.ModifierType.CONTROL_MASK in event.state) {
+
             if (terminal.has_focus && window.get_current_document () != null) {
+
                 window.get_current_document ().focus ();
                 debug ("Move focus: EDITOR.");
                 return true;
+
             } else if (window.get_current_document () != null && window.get_current_document ().source_view.has_focus) {
+
                 terminal.grab_focus ();
                 debug ("Move focus: TERMINAL.");
                 return true;
+
             }
         }
         return false;
     }
 
-    void on_hook (Gtk.Notebook notebook) {
+    void on_hook () {
         this.terminal = new Vte.Terminal ();
         this.terminal.scrollback_lines = -1;
 
@@ -147,19 +182,39 @@
         // Popup menu
         var menu = new Gtk.Menu ();
 
-        var copy = new Gtk.MenuItem.with_label (_("Copy"));
+        // COPY
+        Gtk.MenuItem copy = new Gtk.MenuItem.with_label (_("Copy"));
         copy.activate.connect (() => {
             terminal.copy_clipboard ();
         });
         menu.append (copy);
-        copy.show ();
 
-        var paste = new Gtk.MenuItem.with_label (_("Paste"));
+        // PASTE
+        Gtk.MenuItem paste = new Gtk.MenuItem.with_label (_("Paste"));
         paste.activate.connect (() => {
             terminal.paste_clipboard ();
         });
         menu.append (paste);
-        paste.show ();
+
+        // SEPARATOR
+        menu.append (new Gtk.SeparatorMenuItem ());
+
+        // ON RIGHT
+        location_right = new Gtk.RadioMenuItem.with_label (null, _("Terminal on Right"));
+        location_right.toggled.connect (() => {
+            switch_terminal_location ();
+        });
+        menu.append (location_right);
+
+        // ON BOTTOM
+        location_bottom = new Gtk.RadioMenuItem.with_label (location_right.get_group (), _("Terminal on Bottom"));
+        location_bottom.active = true;
+        location_bottom.toggled.connect (() => {
+            switch_terminal_location ();
+        });
+        menu.append (location_bottom);
+
+        menu.show_all ();
 
         this.terminal.button_press_event.connect ((event) => {
             if (event.button == 3) {
@@ -168,7 +223,7 @@
             }
             return false;
         });
-       
+
         try {
             this.terminal.fork_command_full (Vte.PtyFlags.DEFAULT, "~/", { Vte.get_user_shell () }, null, GLib.SpawnFlags.SEARCH_PATH, null, null);
         } catch (GLib.Error e) {
@@ -184,10 +239,7 @@
         terminal.vexpand = true;
         terminal.hexpand = true;
 
-        notebook.append_page (grid, new Gtk.Label (_("Terminal")));
-
         grid.show_all ();
-
     }
 }
 
@@ -196,4 +248,4 @@
     var objmodule = module as Peas.ObjectModule;
     objmodule.register_extension_type (typeof (Peas.Activatable),
                                      typeof (Scratch.Plugins.Terminal));
-}
\ No newline at end of file
+}

=== modified file 'src/MainWindow.vala'
--- src/MainWindow.vala	2014-11-23 10:44:26 +0000
+++ src/MainWindow.vala	2014-11-24 21:01:57 +0000
@@ -214,13 +214,21 @@
 
             this.contextbar = new Gtk.Notebook ();
             this.contextbar.no_show_all = true;
-            this.contextbar.page_added.connect (() => { on_plugin_toggled (contextbar); });
             this.contextbar.page_removed.connect (() => { on_plugin_toggled (contextbar); });
+            this.contextbar.page_added.connect (() => { 
+                if (!this.split_view.is_empty ())
+                    on_plugin_toggled (contextbar); 
+            });
+            
+
 
             this.bottombar = new Gtk.Notebook ();
             this.bottombar.no_show_all = true;
-            this.bottombar.page_added.connect (() => { on_plugin_toggled (bottombar); });
             this.bottombar.page_removed.connect (() => { on_plugin_toggled (bottombar); });
+            this.bottombar.page_added.connect (() => { 
+                if (!this.split_view.is_empty ())
+                    on_plugin_toggled (bottombar); 
+            });            
 
             hp1 = new Granite.Widgets.ThinPaned ();
             hp2 = new Granite.Widgets.ThinPaned ();
@@ -287,7 +295,7 @@
             set_widgets_sensitive (!split_view.is_empty ());
         }
 
-         private void on_plugin_toggled (Gtk.Notebook notebook) {
+        private void on_plugin_toggled (Gtk.Notebook notebook) {
             var pages = notebook.get_n_pages ();
             notebook.set_show_tabs (pages > 1);
             notebook.no_show_all = (pages == 0);

=== modified file 'src/Widgets/SplitView.vala'
--- src/Widgets/SplitView.vala	2014-10-26 08:26:36 +0000
+++ src/Widgets/SplitView.vala	2014-11-24 21:01:57 +0000
@@ -35,6 +35,7 @@
         public signal void welcome_shown ();
         public signal void welcome_hidden ();
         public signal void document_change (Scratch.Services.Document document);
+        public signal void views_changed (uint count);
 
         private weak MainWindow window;
 
@@ -126,7 +127,6 @@
 
             // Enbale/Disable useless GtkActions about views
             check_actions ();
-
             return view;
         }
 
@@ -199,6 +199,8 @@
         private void check_actions () {
             window.main_actions.get_action ("NewView").sensitive = (views.length () < 2);
             window.main_actions.get_action ("RemoveView").sensitive = (views.length () > 1);
+
+            views_changed (views.length ());
         }
     }
 }
\ No newline at end of file

=== modified file 'src/Widgets/ToolBar.vala'
--- src/Widgets/ToolBar.vala	2014-10-28 18:20:18 +0000
+++ src/Widgets/ToolBar.vala	2014-11-24 21:01:57 +0000
@@ -91,6 +91,7 @@
             pack_start (revert_button);
             pack_start (new SeparatorToolItem ());
             pack_start (find_button);
+            pack_start (find_button);
            
             pack_end (share_app_menu);
             pack_end (zoom_default);
@@ -106,4 +107,4 @@
 
         }
     }
-}
\ No newline at end of file
+}