Granite

Merge lp:~artem-anufrij/granite/set-selected-1 into lp:~elementary-pantheon/granite/granite

  1. set-selected-1
  2. Merge into granite
Proposed by Artem Anufrij
Status: Merged
Merged at revision: 884
Proposed branch: lp:~artem-anufrij/granite/set-selected-1
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 12 lines (+2/-0)
1 file modified
lib/Widgets/ModeButton.vala (+2/-0)
To merge this branch: bzr merge lp:~artem-anufrij/granite/set-selected-1
Reviewer Review Type Date Requested Status
Rico Tzschichholz Needs Fixing
Adam Bieńkowski (community) Approve
Review via email: mp+274197@code.launchpad.net

Commit message

modebutton: Reset _selected to -1 on clear_selected()

Otherwise "mode_changed (new_item.get_child ());" doesn't fire on selected same button.

Description of the change

the varible "_selected" should be set to "-1" in "clear_selected ()". otherwise "mode_changed (new_item.get_child ());" doesn't fire on selected same button.

To post a comment you must log in.
Revision history for this message
Adam Bieńkowski (donadigo) :
review: Approve
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Change this as well:
"if (new_active_index == -1)" >> "if (new_active_index <= -1)" is way safer against weird values

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/ModeButton.vala'
2--- lib/Widgets/ModeButton.vala 2015-10-04 10:40:52 +0000
3+++ lib/Widgets/ModeButton.vala 2015-10-12 23:35:41 +0000
4@@ -143,6 +143,8 @@
5 if (item != null && item.active)
6 item.set_active (false);
7 }
8+
9+ _selected = -1;
10 }
11
12 /**

Subscribers

People subscribed via source and target branches