Code review comment for lp:~artem-anufrij/audience/playlist-rewrite

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Conflicts with trunk. I tested after merging and resolving conflicts.

Compilation warnings:
Bottom Bar: playlist_item.added not used.
PlayList::add_from_file - unhandled GLib.Error, misaligned lines

variable name instand_play should be "instant play".
some formatting issues (see inline)

Add and remove icons not consistent with other elementary apps - use + - buttons at bottom?
Use of trash icon misleading. User might think the original video will be trashed?
Playlist too narrow when empty - need empty message?

After adding file(s) they do not appear until playlist hidden/opened or app restarted.

review: Needs Fixing (code, ui, function)

« Back to merge proposal