Merge lp:~artem-anufrij/audience/dynamic-repeat-button into lp:~audience-members/audience/trunk

Proposed by Artem Anufrij
Status: Merged
Approved by: Cody Garver
Approved revision: 507
Merged at revision: 506
Proposed branch: lp:~artem-anufrij/audience/dynamic-repeat-button
Merge into: lp:~audience-members/audience/trunk
Diff against target: 82 lines (+12/-16)
2 files modified
src/Audience.vala (+9/-13)
src/CMakeLists.txt (+3/-3)
To merge this branch: bzr merge lp:~artem-anufrij/audience/dynamic-repeat-button
Reviewer Review Type Date Requested Status
Cody Garver Approve
Review via email: mp+254481@code.launchpad.net

Commit message

Show filename with the Replay button (lp:1403247)

Description of the change

Repeat button shows name of last video (see screenshot), or "Replay last playlist" if playlist has more than one item.

To post a comment you must log in.
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :
Revision history for this message
Cody Garver (codygarver) wrote :

src/CMakeLists.txt line 14 needs to specific the version of granite required

review: Needs Fixing
507. By Artem Anufrij

CMakeList: 'granite' changed to 'granite>=0.3.0'

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

CMakeList: 'granite' changed to 'granite>=0.3.0'

Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Audience.vala'
2--- src/Audience.vala 2015-03-22 10:49:25 +0000
3+++ src/Audience.vala 2015-03-28 15:27:29 +0000
4@@ -234,13 +234,13 @@
5 Idle.add (() => { video_player.progress = 0; return false; });
6 video_player.playing = true;
7 } else {
8+ var button = welcome.get_button_from_index (2);
9 welcome.set_item_visible (1, false);
10+ welcome.set_item_visible (2, true);
11 if (last_played_index > 0) {
12- welcome.set_item_visible (2, false);
13- welcome.set_item_visible (3, true);
14+ button.description = _("Replay last playlist");
15 } else {
16- welcome.set_item_visible (2, true);
17- welcome.set_item_visible (3, false);
18+ button.description = _("Replay '%s'").printf (get_title (playlist.get_first_item ().get_basename ()));
19 }
20
21 welcome.show_all ();
22@@ -380,22 +380,19 @@
23 welcome.append ("media-playlist-repeat", _("Replay"), _("Replay last video"));
24 welcome.set_item_visible (2, false);
25
26- welcome.append ("media-playlist-repeat", _("Replay"), _("Replay last playlist"));
27+ welcome.append ("media-cdrom", _("Play from Disc"), _("Watch a DVD or open a file from disc"));
28 welcome.set_item_visible (3, false);
29
30- welcome.append ("media-cdrom", _("Play from Disc"), _("Watch a DVD or open a file from disc"));
31- welcome.set_item_visible (4, false);
32-
33 //look for dvd
34 var disk_manager = DiskManager.get_default ();
35- welcome.set_item_visible (4, disk_manager.has_media_volumes ());
36+ welcome.set_item_visible (3, disk_manager.has_media_volumes ());
37
38 disk_manager.volume_found.connect ((vol) => {
39- welcome.set_item_visible (4, disk_manager.has_media_volumes ());
40+ welcome.set_item_visible (3, disk_manager.has_media_volumes ());
41 });
42
43 disk_manager.volume_removed.connect ((vol) => {
44- welcome.set_item_visible (4, disk_manager.has_media_volumes ());
45+ welcome.set_item_visible (3, disk_manager.has_media_volumes ());
46 });
47
48
49@@ -416,7 +413,6 @@
50 video_player.playing = true;
51 break;
52 case 2:
53- case 3:
54 welcome.hide ();
55 clutter.show_all ();
56 open_file (playlist.get_first_item ().get_path ());
57@@ -424,7 +420,7 @@
58 Idle.add (() => {video_player.progress = 0; return false;});
59 video_player.playing = true;
60 break;
61- case 4:
62+ case 3:
63 run_open_dvd ();
64 break;
65 default:
66
67=== modified file 'src/CMakeLists.txt'
68--- src/CMakeLists.txt 2014-10-14 09:03:22 +0000
69+++ src/CMakeLists.txt 2015-03-28 15:27:29 +0000
70@@ -11,9 +11,9 @@
71 # pkgconfig, real C code
72 find_package (PkgConfig)
73
74-set (PKG_DEPS granite clutter-gtk-1.0 gstreamer-1.0 gstreamer-pbutils-1.0 gstreamer-tag-1.0)
75-set (VALA_DEPS
76- granite
77+set (PKG_DEPS granite>=0.3.0 clutter-gtk-1.0 gstreamer-1.0 gstreamer-pbutils-1.0 gstreamer-tag-1.0)
78+set (VALA_DEPS
79+ granite>=0.3.0
80 clutter-gtk-1.0
81 gdk-x11-3.0
82 gstreamer-1.0

Subscribers

People subscribed via source and target branches