Merge lp:~artem-anufrij/audience/Bugfix-1386040 into lp:~audience-members/audience/trunk

[Artem Anufrij]

Check privacy mode. IF ENABLED: don't save the settings (last videos, current video, process, last folder).

[Viko Adi Rahmawan (vikoadi)]

I think this process of defining what to save and what to open is a really complex task. As we see in the switchboard we have a blacklisting based on file path and what open it.

Checking this gsettings might be not enough and we need a more sophisticated process involving Zeitgeist , Gtk.RecentManager, etc. And it might be useful for other project too, it would be awesome if it can be a part of Granite.

I don't know about how Security and Privacy is designed in pantheon, and i think it need to be discussed in a bigger forum.

[Danielle Foré (danrabbit)]

I think for the purpose of this bug report, it would be acceptable to just not write any changes to gsettings while privacy mode is active.

Unmerged revisions

460. By artem-anufrij on 2014-11-11

Check privacy mode. IF ENABLE: don't save the settings (last videos, current video, process, last folder).

459. By artem-anufrij on 2014-11-11

Check privacy mode. IF ENABLE: don't save the settings (last videos, current video, process).

=== modified file 'src/Audience.vala'
--- src/Audience.vala	2014-11-02 19:13:36 +0000
+++ src/Audience.vala	2014-11-11 19:21:39 +0000
@@ -583,6 +583,12 @@
         }
 
         private void on_destroy () {
+
+            if (is_privacy_mode_enabled ()) {
+                clear_video_settings ();
+                return;
+            }
+
             if (video_player.uri.has_prefix ("dvd://")) {
                 clear_video_settings ();
                 return;
@@ -642,9 +648,9 @@
             settings.last_stopped = 0;
             settings.last_played_videos = null;
             settings.current_video = "";
+            settings.last_folder = "";
         }
 
-
         private void restore_playlist () {
             foreach (var filename in settings.last_played_videos) {
                 playlist.add_item (File.new_for_uri (filename));
@@ -802,6 +808,10 @@
         //the application started
         public override void activate () {
             build ();
+
+            if (is_privacy_mode_enabled ())
+                return;
+
             if (settings.resume_videos == true
                 && settings.last_played_videos.length > 0
                 && settings.current_video != ""
@@ -838,6 +848,11 @@
             } else
                 open_file(files[0].get_uri ());
         }
+
+        public bool is_privacy_mode_enabled () {
+            var privacy_settings = new GLib.Settings ("org.gnome.desktop.privacy");
+            return privacy_settings.get_boolean ("remember-recent-files") || privacy_settings.get_boolean ("remember-app-usage");
+        }
     }
 }
 
@@ -854,4 +869,4 @@
     var app = Audience.App.get_instance ();
 
     app.run (args);
-}
\ No newline at end of file
+}