Code review comment for lp:~aristobulo/web-addons/web_fields_masks

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

You should put library files into /static/lib (why? If another module uses the same library, it would be loaded twice otherwise and is likely to clash)

Further, #2492 means we can't have apostrophes or quotes in the input mask. Why don't you simply eval() this attribute? This way, the user can fill in either a simple input mask or an object as applicable?

What would be nice is if you set the standard OpenERP error class (oe_form_invalid) if the user's input doesn't match the mask.

review: Needs Fixing

« Back to merge proposal