~arif-ali/+git/sos:snapcraft_update

Last commit made on 2022-01-27
Get this branch:
git clone -b snapcraft_update https://git.launchpad.net/~arif-ali/+git/sos
Only Arif Ali can upload to this branch. If you are Arif Ali please log in for upload directions.

Branch merges

Branch information

Name:
snapcraft_update
Repository:
lp:~arif-ali/+git/sos

Recent commits

5d2914f... by Arif Ali

[snapcraft] Update snapcraft.yaml

After testing directly from snapcraft server, there was an
issue wrt classic snaps and paths. This update resolved this
particular issue

Signed-off-by: Arif Ali <email address hidden>

790d6d6... by Pavel Moravec <email address hidden>

[virsh] Catch parsing exception

In case virsh output is malformed or missing 'Name' otherwise,
catch parsing exception and continue in next for loop iteration.

Resolves: #2836

Signed-off-by: Pavel Moravec <email address hidden>

210b83e... by Daniel Alvarez

[ovn_central] Account for Red Hat ovn package naming

Previous ovn packages were 'ovn2xxx' and now they have
been renamed to 'ovn-2xxx'. This causes sos tool to not
recognize that the packages are installed and it won't
collect the relevant data.

This patch is changing the match to be compatible
with the previous and newer naming conventions.

Signed-off-by: Daniel Alvarez Sanchez <email address hidden>

ade857c... by Jake Hunsaker <email address hidden>

[collect] Update docstrings for collect for help command

Updates the docstrings for collect components for the new `help`
command, including minor formatting changes to make the help output more
human-friendly.

This includes docstring updates and changes to transports and cluster
profiles.

Signed-off-by: Jake Hunsaker <email address hidden>

4ece528... by Jake Hunsaker <email address hidden>

[policies, redhat] Add docstring text for RH policies for sos help

Adds helpful documentation to the docstrings for various Red Hat
policies to provide more information via the new `sos help` command.

Signed-off-by: Jake Hunsaker <email address hidden>

f320254... by Jake Hunsaker <email address hidden>

[plugins] Update a few common plugins for new help output

Updates four common plugins to provide several examples of how to format
plugin documentation so that the new `help` component is able to provide
useful information on them.

Going forward, new plugins should include docstrings to provide this
help information as part of the initial review process. Existing plugins
will be updated as time allows or as plugins are updated and/or
refactored.

Signed-off-by: Jake Hunsaker <email address hidden>

203e43a... by Jake Hunsaker <email address hidden>

[sos] Add 'help' component for enhanced help information

This commit marks the beginning of the addition of a new `help`
component for sos, which will be used to display more in-depth help
information surrounding all the different components of sos.

The command is intended to be invoked with a specific help topic in
mind, that mirrors our project layout. E.G. to get help on the report
component, a user would use `sos help report`, whereas to get help on a
specific plugin a user would use `sos help report.plugins.$plugin`.

This first commit includes both the initial framework for the `help`
component, as well as updating `SoSReport` and `Plugin` to provide a
basic implementation for the new subcommand. Additionally, `Policy` is
given a basic framework for existing policies to report certain default
values as well as available presets. A stub section is provided for the
base `RedHatPolicy` to serve as a redirector for the actually used
policies that subclass it.

Closes: #2205

72c86d6... by Jake Hunsaker <email address hidden>

[mac_parser] Skip parsing of modinfo output

Skip parsing of modinfo output by the mac parser, as this can lead to
numerous false positive matches and unhelpfully obfuscate the signature
of modules.

Signed-off-by: Jake Hunsaker <email address hidden>

0677444... by Nikhil Kakade <email address hidden>

[cleaner] Update regex for finding IPv4/v6 addresses

The regex trys to match a single character not present
in the given list [^:|-]. The string which starts with
addresses are left out as there is
no character to match.

Adding ? to matches the previous token between zero and one time.

Resolves Issue: #2829

Signed-off-by: Nikhil Kakade <email address hidden>

5634f7d... by Pavel Moravec <email address hidden>

[foreman] Use psql-msgpack-decode wrapper for dynflow >= 1.6

In dynflow >=1.6.3, dynflow* tables in postgres are encoded by
msgpack which makes plain CSV dumps unreadable. In such a case,
psql-msgpack-decode wrapper tool from dynflow-utils (of any
version) must be used instead of the plain psql command.

Resolves: #2830

Signed-off-by: Pavel Moravec <email address hidden>