Merge lp:~ari-tczew/ubuntu/maverick/agg/lp-393923 into lp:ubuntu/maverick/agg

[Artur Rona]

[Stefano Rivera (stefanor)]

+ * debian/control: Add depends field including Depends: ${misc:Depends}
+ for fix debhelper-but-no-misc-depends

Unnecessary diversion from debian (does it actually expand to anything?), but please file a bug with them about this.

+ * debian/README.source: Fix patch-system-but-no-source-readme

Unnecessary diversion from debian, and I don't even see it in the diff, did you bzr add it?

+ * debian/patches/06_fix_missing_includes.dpatch: Fix missing
+ includes causes compilation problem. (LP: #393923)

I don't see it in the diff, did you bzr add it?

review: Needs Fixing

[lp:~ari-tczew/ubuntu/maverick/agg/lp-393923]

11. By Artur Rona on 2010-08-23

  includes causes compilation problem. (LP: #393923, Closes: #575620)

12. By Artur Rona on 2010-08-23

Fix some issues suggested by Stefano.

[Artur Rona (ari-tczew)]

Fixed, ready for review again.

review: Needs Resubmitting

=== modified file 'debian/changelog'
--- debian/changelog	2009-11-20 19:10:21 +0000
+++ debian/changelog	2010-08-23 10:57:40 +0000
@@ -1,3 +1,12 @@
+agg (2.5+dfsg1-3ubuntu1) maverick; urgency=low
+
+  * debian/patches/06_fix_missing_includes.dpatch: Fix missing
+    includes causes compilation problem. (LP: #393923, Closes: #575620)
+  * debian/patches/05_fix_recursion_crash.dpatch: Update patch,
+    it's necessary to fix compilation problem.
+
+ -- Artur Rona <[e-mail]>  Mon, 23 Aug 2010 01:34:28 +0200
+
 agg (2.5+dfsg1-3) unstable; urgency=low
 
   * debian/patches/05_fix_recursion_crash:

=== modified file 'debian/control'
--- debian/control	2009-11-20 19:10:21 +0000
+++ debian/control	2010-08-23 10:57:40 +0000
@@ -1,6 +1,7 @@
 Source: agg
 Priority: optional
-Maintainer: Andrea Veri <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Andrea Veri <[e-mail]>
 Build-Depends: debhelper (>= 7), dpatch, autoconf, automake1.9, libsdl1.2-dev, libfreetype6-dev, pkg-config, libtool, libx11-dev
 Standards-Version: 3.8.3
 DM-Upload-Allowed: yes

=== modified file 'debian/patches/00list'
--- debian/patches/00list	2009-11-20 19:10:21 +0000
+++ debian/patches/00list	2010-08-23 10:57:40 +0000
@@ -3,3 +3,4 @@
 03_pkg_config_pic.dpatch
 04_no_rpath
 05_fix_recursion_crash.dpatch
+06_fix_missing_includes.dpatch

=== modified file 'debian/patches/05_fix_recursion_crash.dpatch'
--- debian/patches/05_fix_recursion_crash.dpatch	2009-11-20 19:10:21 +0000
+++ debian/patches/05_fix_recursion_crash.dpatch	2010-08-23 10:57:40 +0000
@@ -3,7 +3,7 @@
 ##
 ## All lines beginning with `## DP:' are a description of the patch.
 ## DP: Ubuntu: http://launchpad.net/bugs/344849
-## DP: Patch: https://trac.mapnik.org/ticket/253
+## DP: Patch: https://trac.mapnik.org/ticket/253, http://trac.mapnik.org/changeset/1801
 ## DP: Description: Avoid a crash caused by an infinite recursion when drawing extremely long lines
 
 @DPATCH@
@@ -16,8 +16,8 @@
              int cy = (y1 + y2) >> 1;
 +
 +            // Bail if values are so large they are likely to wrap
-+            if ((abs(x1) >= INT_MAX/2) || (abs(y1) >= INT_MAX/2) ||
-+                (abs(x2) >= INT_MAX/2) || (abs(y2) >= INT_MAX/2))
++            if ((std::abs(x1) >= std::numeric_limits<int>::max()/2) || (std::abs(y1) >= std::numeric_limits<int>::max()/2) ||
++                (std::abs(x2) >= std::numeric_limits<int>::max()/2) || (std::abs(y2) >= std::numeric_limits<int>::max()/2))
 +                    return;
 +
              line(x1, y1, cx, cy);

=== added file 'debian/patches/06_fix_missing_includes.dpatch'
--- debian/patches/06_fix_missing_includes.dpatch	1970-01-01 00:00:00 +0000
+++ debian/patches/06_fix_missing_includes.dpatch	2010-08-23 10:57:40 +0000
@@ -0,0 +1,22 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## From: Artur Rona
+## Description: Add missing includes for fix compile.
+## Bug: https://launchpad.net/bugs/393923
+## Origin: upstream, https://trac.mapnik.org/changeset/1801
+## Author: Dane Springmeyer
+
+@DPATCH@
+
+diff -pruN -x '*~' agg-2.5+dfsg1.orig/include/agg_rasterizer_cells_aa.h agg-2.5+dfsg1/include/agg_rasterizer_cells_aa.h
+--- agg-2.5+dfsg1.orig/include/agg_rasterizer_cells_aa.h	2007-10-11 00:06:16.000000000 +0200
++++ agg-2.5+dfsg1/include/agg_rasterizer_cells_aa.h	2010-08-23 01:51:07.000000000 +0200
+@@ -40,7 +40,8 @@
+ #define AGG_RASTERIZER_CELLS_AA_INCLUDED
+ 
+ #include <string.h>
+-#include <math.h>
++#include <cstdlib>
++#include <limits>
+ #include "agg_math.h"
+ #include "agg_array.h"
+