Merge lp:~ari-tczew/ubuntu/karmic/agg/lp-393923 into lp:ubuntu/karmic/agg

Proposed by Artur Rona
Status: Merged
Merge reported by: Stefano Rivera
Merged at revision: not available
Proposed branch: lp:~ari-tczew/ubuntu/karmic/agg/lp-393923
Merge into: lp:ubuntu/karmic/agg
Diff against target: 76 lines (+35/-3)
4 files modified
debian/changelog (+9/-0)
debian/patches/00list (+1/-0)
debian/patches/06_fix_recursion_crash.dpatch (+3/-3)
debian/patches/07_fix_missing_includes.dpatch (+22/-0)
To merge this branch: bzr merge lp:~ari-tczew/ubuntu/karmic/agg/lp-393923
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+33444@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-04-02 18:39:54 +0000
3+++ debian/changelog 2010-08-23 20:18:45 +0000
4@@ -1,3 +1,12 @@
5+agg (2.5+dfsg1-1ubuntu1.9.10.1) karmic-proposed; urgency=low
6+
7+ * debian/patches/07_fix_missing_includes.dpatch: Fix missing
8+ includes causes compilation problem. (LP: #393923, Closes: #575620)
9+ * debian/patches/06_fix_recursion_crash.dpatch: Update patch,
10+ it's necessary to fix compilation problem.
11+
12+ -- Artur Rona <ari-tczew@tlen.pl> Mon, 23 Aug 2010 01:34:28 +0200
13+
14 agg (2.5+dfsg1-1ubuntu1) jaunty; urgency=low
15
16 [ Andrew Straw ]
17
18=== modified file 'debian/patches/00list'
19--- debian/patches/00list 2009-04-02 18:39:54 +0000
20+++ debian/patches/00list 2010-08-23 20:18:45 +0000
21@@ -4,3 +4,4 @@
22 04_no_rpath
23 05_x11_makefile_am.dpatch
24 06_fix_recursion_crash.dpatch
25+07_fix_missing_includes.dpatch
26
27=== modified file 'debian/patches/06_fix_recursion_crash.dpatch'
28--- debian/patches/06_fix_recursion_crash.dpatch 2009-04-02 18:39:54 +0000
29+++ debian/patches/06_fix_recursion_crash.dpatch 2010-08-23 20:18:45 +0000
30@@ -3,7 +3,7 @@
31 ##
32 ## All lines beginning with `## DP:' are a description of the patch.
33 ## DP: Ubuntu: http://launchpad.net/bugs/344849
34-## DP: Patch: https://trac.mapnik.org/ticket/253
35+## DP: Patch: https://trac.mapnik.org/ticket/253, http://trac.mapnik.org/changeset/1801
36 ## DP: Description: Avoid a crash caused by an infinite recursion when drawing extremely long lines
37
38 @DPATCH@
39@@ -16,8 +16,8 @@
40 int cy = (y1 + y2) >> 1;
41 +
42 + // Bail if values are so large they are likely to wrap
43-+ if ((abs(x1) >= INT_MAX/2) || (abs(y1) >= INT_MAX/2) ||
44-+ (abs(x2) >= INT_MAX/2) || (abs(y2) >= INT_MAX/2))
45++ if ((std::abs(x1) >= std::numeric_limits<int>::max()/2) || (std::abs(y1) >= std::numeric_limits<int>::max()/2) ||
46++ (std::abs(x2) >= std::numeric_limits<int>::max()/2) || (std::abs(y2) >= std::numeric_limits<int>::max()/2))
47 + return;
48 +
49 line(x1, y1, cx, cy);
50
51=== added file 'debian/patches/07_fix_missing_includes.dpatch'
52--- debian/patches/07_fix_missing_includes.dpatch 1970-01-01 00:00:00 +0000
53+++ debian/patches/07_fix_missing_includes.dpatch 2010-08-23 20:18:45 +0000
54@@ -0,0 +1,22 @@
55+#! /bin/sh /usr/share/dpatch/dpatch-run
56+## From: Artur Rona
57+## Description: Add missing includes for fix compile.
58+## Bug: https://launchpad.net/bugs/393923
59+## Origin: upstream, https://trac.mapnik.org/changeset/1801
60+## Author: Dane Springmeyer
61+
62+@DPATCH@
63+
64+diff -pruN -x '*~' agg-2.5+dfsg1.orig/include/agg_rasterizer_cells_aa.h agg-2.5+dfsg1/include/agg_rasterizer_cells_aa.h
65+--- agg-2.5+dfsg1.orig/include/agg_rasterizer_cells_aa.h 2007-10-11 00:06:16.000000000 +0200
66++++ agg-2.5+dfsg1/include/agg_rasterizer_cells_aa.h 2010-08-23 01:51:07.000000000 +0200
67+@@ -40,7 +40,8 @@
68+ #define AGG_RASTERIZER_CELLS_AA_INCLUDED
69+
70+ #include <string.h>
71+-#include <math.h>
72++#include <cstdlib>
73++#include <limits>
74+ #include "agg_math.h"
75+ #include "agg_array.h"
76+

Subscribers

People subscribed via source and target branches

to all changes: