Merge lp:~arges/nova/fix-lp907152-havana into lp:~ubuntu-server-dev/nova/havana

Proposed by Chris J Arges on 2014-01-09
Status: Superseded
Proposed branch: lp:~arges/nova/fix-lp907152-havana
Merge into: lp:~ubuntu-server-dev/nova/havana
Diff against target: 37 lines (+15/-0)
2 files modified
debian/changelog (+9/-0)
debian/nova-compute.upstart (+6/-0)
To merge this branch: bzr merge lp:~arges/nova/fix-lp907152-havana
Reviewer Review Type Date Requested Status
James Page 2014-01-09 Needs Fixing on 2014-01-13
Review via email: mp+201072@code.launchpad.net

This proposal has been superseded by a proposal from 2014-01-14.

To post a comment you must log in.
James Page (james-page) wrote :

Please could the indentation be fix in the pre-start block please.

review: Needs Fixing
lp:~arges/nova/fix-lp907152-havana updated on 2014-01-14
636. By Chris J Arges on 2014-01-14

[ Jian Wen ]
d/nova-compute.upstart: If libvirt-bin is installed, then wait
for it to reach running state before starting nova-compute
(LP: #907152, #1190280)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-12-19 20:30:10 +0000
3+++ debian/changelog 2014-01-14 18:28:56 +0000
4@@ -1,3 +1,12 @@
5+nova (1:2013.2.1-0ubuntu1.1) saucy-proposed; urgency=low
6+
7+ [ Jian Wen ]
8+ * d/nova-compute.upstart: If libvirt-bin is installed, then wait
9+ for it to reach running state before starting nova-compute
10+ (LP: #907152, #1190280)
11+
12+ -- Chris J Arges <chris.j.arges@canonical.com> Thu, 09 Jan 2014 12:30:55 -0600
13+
14 nova (1:2013.2.1-0ubuntu1) saucy-proposed; urgency=low
15
16 * Resynchronize with stable/havana (a4ffc06) (LP: #1262788):
17
18=== modified file 'debian/nova-compute.upstart'
19--- debian/nova-compute.upstart 2012-12-06 17:46:39 +0000
20+++ debian/nova-compute.upstart 2014-01-14 18:28:56 +0000
21@@ -1,3 +1,4 @@
22+# vim: set ft=upstart et ts=2:
23 description "Nova compute worker"
24 author "Soren Hansen <soren@linux2go.dk>"
25
26@@ -15,6 +16,11 @@
27 chown nova:root /var/lock/nova/
28
29 modprobe nbd
30+
31+ # If libvirt-bin is installed, always wait for it to start first
32+ if status libvirt-bin; then
33+ start wait-for-state WAIT_FOR=libvirt-bin WAIT_STATE=running WAITER=nova-compute
34+ fi
35 end script
36
37 exec start-stop-daemon --start --chuid nova --exec /usr/bin/nova-compute -- --config-file=/etc/nova/nova.conf --config-file=/etc/nova/nova-compute.conf

Subscribers

People subscribed via source and target branches