Scheme Libraries

Code review comment for lp:~arcfide/scheme-libraries/master

master
Merge into srfi

Revision history for this message

Derick Eddington (derick-eddington) wrote on 2012-04-20:

Thanks for the contribution, Aaron! Before I merge it, there are some issues:

The README file needs to be updated to list Chez as a supported system.

I know the text formatting, mentioned in my per-file comments below, isn't a big deal, but I went to efforts to make mine consistent, so I feel like files with my name on them should keep being consistent. In revision 92, I changed all square brackets to parenthesis, because I've come to dislike brackets. In any files that are not Scheme-system-specific, I don't want brackets, but in files that are specific to a Scheme-system that supports brackets, I'm okay with them if it's not attributed to me. Feel free to change the copyright/attribution of the inconsistent files to you, and I'll merge them with whatever formatting and brackets you want. (I don't actually care about copyrighting trivial files, but people told me I need copyrights on everything, and once my name is on them I feel like I described.)

If you'd like, I can use the diff from this merge request, and make the changes I'm suggesting myself.

(FWIW, I hate the "%3a" shit as well as needing ":" to have numbers in library names, and I support Chez not doing the file-name encoding. Screw compatibility with Windows. I gave up on my Library Files SRFI because I doubt all the other systems that do the encoding are going to change at this point. I take the blame for promoting the encoding. I also hate the redundant SRFI-97 short-name alias libraries.)

Below are per-file issues:

%3a38/with-shared-structure.chezscheme.sls

Indentation typo, line 58. It looks like a tab character in there.

Copied from my file, but has square brackets and export/import forms' formatting
has changed.

%3a48/intermediate-format-strings/compat.chezscheme.sls
%3a78/lightweight-testing/compat.chezscheme.sls
%3a98/os-environment-variables.chezscheme.sls

Copied from my file, but export/import forms' formatting has changed.

%3a6/basic-string-ports.chezscheme.sls

To be consistent, I think a %3a6/basic-string-ports/compat.chezscheme.sls should
be used, instead.

.bzrignore

Don't want this file, because it's inherently private-personal-preference.

link-dirs.chezscheme.sps

Do you want your copyright in this file? You put it in your two other non-tiny files. After adding your contribution, I'm going to make a new "utils" directory and move this program and my compile-all.ikarus.sps in to it.

Thanks for the contribution, Aaron!  Before I merge it, there are some issues:

The README file needs to be updated to list Chez as a supported system.

I know the text formatting, mentioned in my per-file comments below, isn't a big deal, but I went to efforts to make mine consistent, so I feel like files with my name on them should keep being consistent.  In revision 92, I changed all square brackets to parenthesis, because I've come to dislike brackets.  In any files that are not Scheme-system-specific, I don't want brackets, but in files that are specific to a Scheme-system that supports brackets, I'm okay with them if it's not attributed to me.  Feel free to change the copyright/attribution of the inconsistent files to you, and I'll merge them with whatever formatting and brackets you want.  (I don't actually care about copyrighting trivial files, but people told me I need copyrights on everything, and once my name is on them I feel like I described.)

If you'd like, I can use the diff from this merge request, and make the changes I'm suggesting myself.

(FWIW, I hate the "%3a" shit as well as needing ":" to have numbers in library names, and I support Chez not doing the file-name encoding.  Screw compatibility with Windows.  I gave up on my Library Files SRFI because I doubt all the other systems that do the encoding are going to change at this point.  I take the blame for promoting the encoding.  I also hate the redundant SRFI-97 short-name alias libraries.)

Below are per-file issues:

%3a38/with-shared-structure.chezscheme.sls

Indentation typo, line 58.  It looks like a tab character in there.

Copied from my file, but has square brackets and export/import forms' formatting
has changed.

%3a48/intermediate-format-strings/compat.chezscheme.sls
%3a78/lightweight-testing/compat.chezscheme.sls
%3a98/os-environment-variables.chezscheme.sls

Copied from my file, but export/import forms' formatting has changed.

%3a6/basic-string-ports.chezscheme.sls

To be consistent, I think a %3a6/basic-string-ports/compat.chezscheme.sls should
be used, instead.

.bzrignore

Don't want this file, because it's inherently private-personal-preference.

link-dirs.chezscheme.sps

Do you want your copyright in this file?  You put it in your two other non-tiny files.  After adding your contribution, I'm going to make a new "utils" directory and move this program and my compile-all.ikarus.sps in to it.

review: Needs Fixing

« Back to merge proposal