Merge lp:~arashbm/ubuntu-weather-app/translation-string into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Arash Badie Modiri
Status: Merged
Approved by: Raúl Yeguas
Approved revision: 176
Merged at revision: 185
Proposed branch: lp:~arashbm/ubuntu-weather-app/translation-string
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 195 lines (+39/-50)
2 files modified
components/AddLocationSheet.qml (+1/-1)
po/ubuntu-weather-app.pot (+38/-49)
To merge this branch: bzr merge lp:~arashbm/ubuntu-weather-app/translation-string
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Approve
Adolfo Jayme Barrientos (community) Approve
Review via email: mp+201690@code.launchpad.net

Commit message

changed a translation string into something a little bit more general

Description of the change

changed a translation string into something a little bit more general to support Persian and other languages that don't have nouns at the end of sentence.

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Thanks a lot! The change looks good to me and makes sense.

Could you also please update the .pot file? Once you've done it and pushed it to your branch, this merge proposal should get updated automatically for you.

The steps on how to update the .pot file are described in http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/trunk/view/head:/README.translations

review: Needs Fixing
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

Thank you!

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Looks good to me, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~arashbm/ubuntu-weather-app/translation-string/+merge/201690/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components/AddLocationSheet.qml'
2--- components/AddLocationSheet.qml 2013-10-04 15:26:59 +0000
3+++ components/AddLocationSheet.qml 2014-01-14 23:22:44 +0000
4@@ -67,7 +67,7 @@
5 //
6 if (!citiesModel.count) {
7 noCityError.visible = true
8- noCityError.text = i18n.tr("No location was found for ") + locationString.text
9+ noCityError.text = i18n.tr("No location was found for %1").arg(locationString.text)
10 }
11 } else {
12 console.log("search: "+messageObject.error.msg+" / "+messageObject.error.request.url)
13
14=== modified file 'po/ubuntu-weather-app.pot'
15--- po/ubuntu-weather-app.pot 2013-09-26 05:23:41 +0000
16+++ po/ubuntu-weather-app.pot 2014-01-14 23:22:44 +0000
17@@ -8,7 +8,7 @@
18 msgstr ""
19 "Project-Id-Version: ubuntu-weather-app\n"
20 "Report-Msgid-Bugs-To: \n"
21-"POT-Creation-Date: 2013-09-26 07:22+0200\n"
22+"POT-Creation-Date: 2014-01-15 02:51+0330\n"
23 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
24 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
25 "Language-Team: LANGUAGE <LL@li.org>\n"
26@@ -17,44 +17,45 @@
27 "Content-Type: text/plain; charset=CHARSET\n"
28 "Content-Transfer-Encoding: 8bit\n"
29
30-#: ../components/AddLocationSheet.qml:30
31-#: ../components/LocationManagerSheet.qml:215
32+#: ../components/AddLocationSheet.qml:32
33+#: ../components/LocationManagerSheet.qml:268
34 msgid "Add city"
35 msgstr ""
36
37-#: ../components/AddLocationSheet.qml:77
38-msgid "No location was found for "
39+#: ../components/AddLocationSheet.qml:70
40+#, qt-format
41+msgid "No location was found for %1"
42 msgstr ""
43
44-#: ../components/AddLocationSheet.qml:126
45+#: ../components/AddLocationSheet.qml:128
46 msgid "Enter a city name"
47 msgstr ""
48
49-#: ../components/CurrentWeather.qml:136
50+#: ../components/CurrentWeather.qml:154
51 msgid "Humidity"
52 msgstr ""
53
54-#: ../components/CurrentWeather.qml:152
55+#: ../components/CurrentWeather.qml:170
56 msgid "Wind speed"
57 msgstr ""
58
59-#: ../components/CurrentWeather.qml:177
60+#: ../components/CurrentWeather.qml:195
61 msgid "Pressure"
62 msgstr ""
63
64-#: ../components/CurrentWeather.qml:178
65+#: ../components/CurrentWeather.qml:196
66 msgid "mbar"
67 msgstr ""
68
69-#: ../components/CurrentWeather.qml:192
70+#: ../components/CurrentWeather.qml:211
71 msgid "Precipitation"
72 msgstr ""
73
74-#: ../components/LastUpdatedComponent.qml:32
75+#: ../components/LastUpdatedComponent.qml:33
76 msgid "Updated: "
77 msgstr ""
78
79-#: ../components/LastUpdatedComponent.qml:36
80+#: ../components/LastUpdatedComponent.qml:37
81 msgid "Today, "
82 msgstr ""
83
84@@ -66,88 +67,76 @@
85 msgid "Edit locations"
86 msgstr ""
87
88-#: ../components/LocationManagerSheet.qml:84
89+#: ../components/LocationManagerSheet.qml:104
90 msgid "Current location"
91 msgstr ""
92
93-#: ../components/LocationManagerSheet.qml:102
94-msgid "Lookup location"
95+#: ../components/LocationManagerSheet.qml:124
96+msgid "Scan for location"
97 msgstr ""
98
99 #. TRANSLATORS: this is the button to add a location (city) that has been
100 #. detected to be the current position
101-#: ../components/LocationManagerSheet.qml:134
102+#: ../components/LocationManagerSheet.qml:187
103 msgid "Add"
104 msgstr ""
105
106-#: ../components/LocationManagerSheet.qml:150
107+#: ../components/LocationManagerSheet.qml:204
108 msgid "World"
109 msgstr ""
110
111-#: ../components/LocationManagerSheet.qml:233
112+#: ../components/LocationManagerSheet.qml:286
113 msgid "Location already added."
114 msgstr ""
115
116-#: ../components/LocationManagerSheet.qml:235
117+#: ../components/LocationManagerSheet.qml:288
118 msgid "OK"
119 msgstr ""
120
121-#: ../components/LocationTab.qml:164
122+#: ../components/LocationManagerSheet.qml:345
123+msgid "Couldn't specify your current location, please try later again!"
124+msgstr ""
125+
126+#: ../components/LocationTab.qml:167
127 msgid ""
128 "No weather data available at the moment, please try to refresh later again!"
129 msgstr ""
130
131-#: ../components/LocationTab.qml:180
132+#: ../components/LocationTab.qml:200
133 msgid "Refresh"
134 msgstr ""
135
136-#: ../components/LocationTab.qml:192
137+#: ../components/LocationTab.qml:213
138 msgid "Edit"
139 msgstr ""
140
141-#: ../components/LocationTab.qml:204 ../components/SettingsSheet.qml:27
142+#: ../components/LocationTab.qml:225 ../components/SettingsSheet.qml:27
143 msgid "Settings"
144 msgstr ""
145
146-#: ../components/SettingsSheet.qml:36
147+#: ../components/SettingsSheet.qml:51
148 msgid "Temperature units"
149 msgstr ""
150
151-#: ../components/SettingsSheet.qml:37
152-msgid "Celsius"
153-msgstr ""
154-
155-#: ../components/SettingsSheet.qml:37
156-msgid "Fahrenheit"
157-msgstr ""
158-
159-#: ../components/SettingsSheet.qml:43
160+#: ../components/SettingsSheet.qml:66
161 msgid "Wind speed units"
162 msgstr ""
163
164-#: ../components/SettingsSheet.qml:44
165-msgid "Kilometers per hour"
166-msgstr ""
167-
168-#: ../components/SettingsSheet.qml:44
169-msgid "Miles per hour"
170-msgstr ""
171-
172-#: ../components/SplashComponent.qml:34
173+#: ../components/SettingsSheet.qml:81
174+msgid "Precipitation units"
175+msgstr ""
176+
177+#: ../components/SplashComponent.qml:33
178 msgid "Couldn't load weather data, please try later again!"
179 msgstr ""
180
181-#: ../components/SwipeDelete.qml:52 ../components/SwipeDelete.qml:60
182-msgid "Delete"
183-msgstr ""
184-
185 #. TRANSLATORS: this refers to the High (max) temperature forecasted for a day
186-#: ../components/WeatherTemperatureComponent.qml:84
187+#: ../components/WeatherTemperatureComponent.qml:102
188 msgid "H:"
189 msgstr ""
190
191 #. TRANSLATORS: this refers to the Low (min) temperature forecasted for a day
192-#: ../components/WeatherTemperatureComponent.qml:104
193+#: ../components/WeatherTemperatureComponent.qml:122
194 msgid "L:"
195 msgstr ""
196

Subscribers

People subscribed via source and target branches