Merge lp:~ara/mago/tweaks into lp:~mago-contributors/mago/mago-1.0

[Ara Pulido]

[Ara Pulido (ara)]

Generating a keyevent like "<ctrl><alt>d" to minimize all the windows in the screen is not very robust (sometimes it fails) and it dependent on the user's configuration.

This change propose to use wnck to minimize the windows. This works robustly and it is configuration independent.

[Javier Collado (javier.collado)]

Hello,

I've never used wcnk library (is there any documentation available?), but I've tried the code in my laptop and it's worked fine.

Best regards,
    Javier

review: Approve

[Joker Wild (lajjr-deactivatedaccount)]

Javier,

> I've never used wcnk library (is there any documentation available?), but I've
> tried the code in my laptop and it's worked fine.
I found this for you I hope it helps.
http://library.gnome.org/devel/libwnck/stable/

Regards,
Leo

[Javier Collado (javier.collado)]

> Javier,
>
> > I've never used wcnk library (is there any documentation available?), but
> I've
> > tried the code in my laptop and it's worked fine.
> I found this for you I hope it helps.
> http://library.gnome.org/devel/libwnck/stable/
>
> Regards,
> Leo

Thanks Leo. I now see that part of the problem was that I wasn't spelling correctly the name of the library.

[Ara Pulido (ara)]

The documentation Leo provided, is the C library. I haven't found any documentation for the python bindings.

[Nagappan Alagappan (nagappan)]

Hi Ara,

I think, this is the best way to do.

Thanks
Nagappan

On Mon, Jun 15, 2009 at 1:50 AM, Ara Pulido <email address hidden> wrote:

> Ara Pulido has proposed merging lp:~apulido/mago/tweaks into lp:mago.
>
> Requested reviews:
> Mago Contributors (mago-contributors)
>
> Generating a keyevent like "<ctrl><alt>d" to minimize all the windows in
> the screen is not very robust (sometimes it fails) and it dependent on the
> user's configuration.
>
> This change propose to use wnck to minimize the windows. This works
> robustly and it is configuration independent.
> --
> https://code.launchpad.net/~apulido/mago/tweaks/+merge/7445<https://code.launchpad.net/%7Eapulido/mago/tweaks/+merge/7445>
> You are subscribed to branch lp:mago.
>

--
Linux Desktop (GUI Application) Testing Project -
http://ldtp.freedesktop.org
http://nagappanal.blogspot.com

=== modified file 'mago/application/deskex.py'
--- mago/application/deskex.py	2009-05-14 09:29:37 +0000
+++ mago/application/deskex.py	2009-06-15 08:41:09 +0000
@@ -1,4 +1,5 @@
 from .main import Application
+from ..utils import minimize_all_windows
 from time import time, sleep
 import tempfile
 import pynotify
@@ -137,11 +138,11 @@
         self.focus_desktop = focus_desktop
 
         if self.focus_desktop:
-            ldtp.generatekeyevent('<alt><ctrl>d')
+            minimize_all_windows()
 
     def close(self):
         if self.focus_desktop:
-            ldtp.generatekeyevent('<alt><ctrl>d')
+            minimize_all_windows()
         for screenshot in self.screenshots:
             if os.path.exists(screenshot):
                 os.remove(screenshot)

=== modified file 'mago/utils.py'
--- mago/utils.py	2009-05-06 09:35:24 +0000
+++ mago/utils.py	2009-06-15 08:41:09 +0000
@@ -1,4 +1,16 @@
 import os
+import gtk, gobject, wnck
+
+def minimize_all_windows():
+    def start_minimizing():
+        for w in screen.get_windows():
+            w.minimize()
+
+
+    screen = wnck.screen_get_default()
+    gobject.idle_add(start_minimizing)
+    gobject.idle_add(gtk.main_quit)
+    gtk.main()
 
 def get_system_language():
     raise NotImplementedError, "not yet..."