Merge lp:~apw/ubuntu-archive-tools/i386-whitelist--intuit-nvidia-versions into lp:ubuntu-archive-tools

Proposed by Andy Whitcroft
Status: Merged
Merged at revision: 1482
Proposed branch: lp:~apw/ubuntu-archive-tools/i386-whitelist--intuit-nvidia-versions
Merge into: lp:ubuntu-archive-tools
Diff against target: 28 lines (+11/-7)
1 file modified
update-i386-whitelist (+11/-7)
To merge this branch: bzr merge lp:~apw/ubuntu-archive-tools/i386-whitelist--intuit-nvidia-versions
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+404567@code.launchpad.net

Commit message

Switch nvidia-graphics-drivers-* selection from an "exhaustive" future set to those actually coming down the pipe.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) :
review: Approve
Revision history for this message
Steve Langasek (vorlon) wrote :

I see this is already approved and merged, which is fine; but what is the practical impact of this change? I think this only affects the output on the commandline, because if a package doesn't exist in the target, launchpad accepts the api call but doesn't add it to the packageset.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'update-i386-whitelist'
2--- update-i386-whitelist 2021-05-20 09:04:42 +0000
3+++ update-i386-whitelist 2021-06-23 11:44:16 +0000
4@@ -135,13 +135,17 @@
5 except KeyError:
6 pass
7
8- nv_list = []
9- for nv_flavour in range(440, 1005, 5):
10- nvidia_pkg = 'nvidia-graphics-drivers-%s' % (nv_flavour)
11- nv_list.append(nvidia_pkg)
12- nvidia_pkg += '-server'
13- nv_list.append(nvidia_pkg)
14- newSet.update(nv_list)
15+ nvSet = set()
16+ for archive_reference in (
17+ 'ubuntu',
18+ 'ppa:oem-solutions-group/ubuntu/nvidia-driver-staging',
19+ 'ppa:albertomilone/ubuntu/nvidia-testing',
20+ ):
21+ archive = launchpad.archives.getByReference(reference=archive_reference)
22+ srcs = archive.getPublishedSources(distro_series=series, source_name='nvidia-graphics-drivers-', status='Published')
23+ for src in srcs:
24+ nvSet.add(src.source_package_name)
25+ newSet.update(nvSet)
26
27 print("Additions:" )
28 additions = list(newSet-currentSet)

Subscribers

People subscribed via source and target branches