Merge lp:~apw/lightdm/lp1203711-fix-uninitialised-glist into lp:lightdm

Proposed by Andy Whitcroft
Status: Merged
Approved by: Robert Ancell
Approved revision: 1721
Merged at revision: 1721
Proposed branch: lp:~apw/lightdm/lp1203711-fix-uninitialised-glist
Merge into: lp:lightdm
Diff against target: 12 lines (+1/-1)
1 file modified
src/lightdm.c (+1/-1)
To merge this branch: bzr merge lp:~apw/lightdm/lp1203711-fix-uninitialised-glist
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Ancell Approve
Review via email: mp+176193@code.launchpad.net

Commit message

fix uninitialised GList pointer in configuration directory handling (LP: #1203711)

Description of the change

Fixes early startup crashes triggered by an uninitialised GList being used for the configuration directory listing.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1721
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~apw/lightdm/lp1203711-fix-uninitialised-glist/+merge/176193/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/lightdm-ci/130/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/lightdm-saucy-amd64-ci/46

Click here to trigger a rebuild:
http://s-jenkins:8080/job/lightdm-ci/130/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks Andy!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1721
http://jenkins.qa.ubuntu.com/job/lightdm-ci/131/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/lightdm-saucy-amd64-ci/47

Click here to trigger a rebuild:
http://s-jenkins:8080/job/lightdm-ci/131/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/lightdm.c'
2--- src/lightdm.c 2013-07-19 08:56:49 +0000
3+++ src/lightdm.c 2013-07-22 13:31:26 +0000
4@@ -1023,7 +1023,7 @@
5 if (config_d_dir)
6 {
7 GDir *dir;
8- GList *files, *link;
9+ GList *files = NULL, *link;
10 GKeyFile *f;
11
12 /* Find configuration files */

Subscribers

People subscribed via source and target branches