Merge lp:~apparmor-dev/apparmor/apparmor-ubuntu-citrain.lp1288241 into lp:~apparmor-dev/apparmor/apparmor-ubuntu-citrain

Proposed by Jamie Strandboge
Status: Merged
Approved by: Jamie Strandboge
Approved revision: 1499
Merged at revision: 1499
Proposed branch: lp:~apparmor-dev/apparmor/apparmor-ubuntu-citrain.lp1288241
Merge into: lp:~apparmor-dev/apparmor/apparmor-ubuntu-citrain
Diff against target: 80 lines (+21/-18)
6 files modified
debian/apparmor-notify.install (+1/-1)
debian/apparmor-notify.maintscript (+1/-0)
debian/changelog (+9/-1)
debian/notify/90apparmor-notify (+0/-15)
debian/notify/apparmor-notify.desktop (+9/-0)
debian/notify/notify.conf (+1/-1)
To merge this branch: bzr merge lp:~apparmor-dev/apparmor/apparmor-ubuntu-citrain.lp1288241
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Review via email: mp+212887@code.launchpad.net

Description of the change

  * autostart aa-notify via /etc/xdg/autostart instead of /etc/X11/Xsession.d
    (LP: #1288241)
    - remove debian/notify/90apparmor-notify
    - add debian/notify/apparmor-notify.desktop
    - debian/apparmor-notify.install: adjust for the above
    - add debian/apparmor-notify.maintscript to remove 90apparmor-notify
  * debian/notify/notify.conf: use_group should be set to "sudo" instead of
    "admin" (LP: #1009666)

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good, ACK.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/apparmor-notify.install'
2--- debian/apparmor-notify.install 2010-11-04 07:27:37 +0000
3+++ debian/apparmor-notify.install 2014-03-26 16:32:45 +0000
4@@ -1,3 +1,3 @@
5 debian/notify/notify.conf /etc/apparmor/
6-debian/notify/90apparmor-notify /etc/X11/Xsession.d/
7+debian/notify/apparmor-notify.desktop /etc/xdg/autostart
8 usr/sbin/aa-notify /usr/bin/
9
10=== added file 'debian/apparmor-notify.maintscript'
11--- debian/apparmor-notify.maintscript 1970-01-01 00:00:00 +0000
12+++ debian/apparmor-notify.maintscript 2014-03-26 16:32:45 +0000
13@@ -0,0 +1,1 @@
14+rm_conffile /etc/X11/Xsession.d/90apparmor-notify 2.8.95~2430-0ubuntu3~
15
16=== modified file 'debian/changelog'
17--- debian/changelog 2014-03-21 20:05:05 +0000
18+++ debian/changelog 2014-03-26 16:32:45 +0000
19@@ -2,8 +2,16 @@
20
21 * debian/lib/apparmor/functions: properly calculate number of profiles in
22 /var/lib/apparmor/profiles (LP: #1295816)
23+ * autostart aa-notify via /etc/xdg/autostart instead of /etc/X11/Xsession.d
24+ (LP: #1288241)
25+ - remove debian/notify/90apparmor-notify
26+ - add debian/notify/apparmor-notify.desktop
27+ - debian/apparmor-notify.install: adjust for the above
28+ - add debian/apparmor-notify.maintscript to remove 90apparmor-notify
29+ * debian/notify/notify.conf: use_group should be set to "sudo" instead of
30+ "admin" (LP: #1009666)
31
32- -- Jamie Strandboge <jamie@ubuntu.com> Fri, 21 Mar 2014 15:04:14 -0500
33+ -- Jamie Strandboge <jamie@ubuntu.com> Wed, 26 Mar 2014 10:34:34 -0500
34
35 apparmor (2.8.95~2430-0ubuntu2) trusty; urgency=medium
36
37
38=== removed file 'debian/notify/90apparmor-notify'
39--- debian/notify/90apparmor-notify 2010-11-05 00:12:29 +0000
40+++ debian/notify/90apparmor-notify 1970-01-01 00:00:00 +0000
41@@ -1,15 +0,0 @@
42-# ------------------------------------------------------------------
43-#
44-# Copyright (C) 2010 Canonical Ltd.
45-#
46-# This program is free software; you can redistribute it and/or
47-# modify it under the terms of version 2 of the GNU General Public
48-# License published by the Free Software Foundation.
49-#
50-# ------------------------------------------------------------------
51-
52-# Start up apparmor notify. It will read /etc/apparmor/notify.conf and
53-# $HOME/.apparmor/notify.conf for configuration.
54-if [ -x /usr/bin/aa-notify ]; then
55- /usr/bin/aa-notify -p -s 1 -w 60
56-fi
57
58=== added file 'debian/notify/apparmor-notify.desktop'
59--- debian/notify/apparmor-notify.desktop 1970-01-01 00:00:00 +0000
60+++ debian/notify/apparmor-notify.desktop 2014-03-26 16:32:45 +0000
61@@ -0,0 +1,9 @@
62+[Desktop Entry]
63+Type=Application
64+Name=AppArmor Notify
65+Comment=Receive on screen notifications of AppArmor denials
66+TryExec=/usr/bin/aa-notify
67+Exec=/usr/bin/aa-notify -p -s 1 -w 60
68+StartupNotify=false
69+NoDisplay=true
70+X-Ubuntu-Gettext-Domain=aa-notify
71
72=== modified file 'debian/notify/notify.conf'
73--- debian/notify/notify.conf 2010-09-10 19:58:44 +0000
74+++ debian/notify/notify.conf 2014-03-26 16:32:45 +0000
75@@ -12,4 +12,4 @@
76 show_notifications="yes"
77
78 # Only people in use_group can use apparmor-notify
79-use_group="admin"
80+use_group="sudo"

Subscribers

People subscribed via source and target branches

to all changes: