Merge lp:~apatel-serpentcs/openerp-usa/amazon_connector into lp:~faisal-basar/openerp-usa/Amazon-Connector

Proposed by Serpent Consulting Services
Status: Needs review
Proposed branch: lp:~apatel-serpentcs/openerp-usa/amazon_connector
Merge into: lp:~faisal-basar/openerp-usa/Amazon-Connector
Diff against target: 515 lines (+139/-119)
12 files modified
__init__.py (+0/-2)
__openerp__.py (+5/-4)
amazon.py (+5/-3)
amazon_view.xml (+38/-38)
category_attribute.xml (+13/-15)
invoice_stock.py (+11/-1)
partner_view.xml (+2/-2)
product_images_view.xml (+6/-5)
product_view.xml (+41/-34)
sale_view.xml (+13/-11)
security/ir.model.access.csv (+2/-2)
wizard/create_amazon_shop.py (+3/-2)
To merge this branch: bzr merge lp:~apatel-serpentcs/openerp-usa/amazon_connector
Reviewer Review Type Date Requested Status
Faisal Approve
Review via email: mp+176339@code.launchpad.net
To post a comment you must log in.
3. By Anu Patel(SerpentCS)

[IMP] Improved the Code.

Revision history for this message
Faisal (faisal-basar) wrote :

Approved

review: Approve

Unmerged revisions

3. By Anu Patel(SerpentCS)

[IMP] Improved the Code.

2. By Anu Patel(SerpentCS)

[IMP] renamed the branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '__init__.py'
2--- __init__.py 2012-05-08 11:49:19 +0000
3+++ __init__.py 2013-07-23 09:16:27 +0000
4@@ -10,5 +10,3 @@
5 import wizard
6 import invoice_stock
7 import product_images
8-
9-
10
11=== modified file '__openerp__.py'
12--- __openerp__.py 2012-05-08 11:49:19 +0000
13+++ __openerp__.py 2013-07-23 09:16:27 +0000
14@@ -2,15 +2,15 @@
15 {
16 "name" : "Amazon e-commerce",
17 "version" : "1.0",
18- "depends" : ["base","product","sale",'base_sale_multichannels','product_images_olbs'],
19+ "depends" : ["base","product","sale",'base_sale_multichannels','product_images'],
20 "author" : "Bista Solutions",
21 "description": """Amazon E-commerce management""",
22 "website" : "http://www.bistasolutions.com/",
23 "category" : "Generic Modules",
24 "init_xml" : [],
25 "demo_xml" : [],
26- "update_xml" : [
27- 'security/ir.model.access.csv',
28+ 'data': [
29+ 'security/ir.model.access.csv',
30 'amazon_view.xml',
31 'product_view.xml',
32 'partner_view.xml',
33@@ -21,7 +21,8 @@
34 'category_attribute.xml',
35 'wizard/amazon_product_lookup.xml',
36 'product_images_view.xml',
37- 'magento_sale.xml'
38+ 'magento_sale.xml',
39+
40 ],
41 "active": False,
42 "installable": True,
43
44=== modified file 'amazon.py'
45--- amazon.py 2012-05-08 11:49:19 +0000
46+++ amazon.py 2013-07-23 09:16:27 +0000
47@@ -106,7 +106,8 @@
48 postalcode = resultvals['PostalCode']
49 else:
50 postalcode = ''
51- address_id = self.pool.get('res.partner.address').search(cr,uid, [('country_id','=',country_id),('state_id','=',state_id),('city','=',city),('street','=',street),('zip','=',postalcode)])
52+ address_id = self.pool.get('res.partner').search(cr,uid, [('country_id','=',country_id),('state_id','=',state_id),('city','=',city),('street','=',street),('zip','=',postalcode)])
53+# address_id = self.pool.get('res.partner.address').search(cr,uid, [('country_id','=',country_id),('state_id','=',state_id),('city','=',city),('street','=',street),('zip','=',postalcode)])
54 if address_id:
55 address_id = address_id
56 if not address_id:
57@@ -118,10 +119,11 @@
58 'phone' : resultvals.get('Phone',False) and resultvals['Phone'] or False,
59 'zip' : postalcode,
60 'state_id' : state_id,
61- 'partner_id' : part_id,
62+# 'partner_id' : part_id,
63 'type' : 'default',
64 }
65- address_id = self.pool.get('res.partner.address').create(cr,uid,addressvals)
66+ address_id = self.pool.get('res.partner').create(cr,uid,addressvals)
67+# address_id = self.pool.get('res.partner.address').create(cr,uid,addressvals)
68 return address_id
69
70 def updatePartner(self, cr, uid, id, shop_id, resultvals, part_id=0, context={}):
71
72=== modified file 'amazon_view.xml'
73--- amazon_view.xml 2012-05-08 11:49:19 +0000
74+++ amazon_view.xml 2013-07-23 09:16:27 +0000
75@@ -3,42 +3,42 @@
76 <data>
77 <!-- Amazon Form -->
78 <record id="amazon_instance_form_view" model="ir.ui.view">
79- <field name="name">amazon.instance.form</field>
80- <field name="type">form</field>
81+ <field name="name">amazon.instance.form</field>
82 <field name="model">amazon.instance</field>
83 <field name="arch" type="xml">
84- <form string="Amazon Instance">
85- <group colspan="4">
86- <field name="name" colspan="4" select="1"/>
87- </group>
88- <notebook colspan="4">
89- <page string="Authentication">
90- <group colspan="4" col="4">
91- <separator string="Amazon Seller Account Credentials" colspan="4"/>
92- <field name="aws_access_key_id"/>
93- <field name="aws_secret_access_key"/>
94- <field name="aws_market_place_id"/>
95- <field name="aws_merchant_id"/>
96-
97- </group>
98- <!--<button name="import_cat" string="Import Categories" colspan="4" type="object" />-->
99- </page>
100- </notebook>
101- </form>
102+ <form string="Amazon Instance" version="7.0">
103+ <sheet>
104+ <group colspan="4">
105+ <field name="name" colspan="4" select="1"/>
106+ </group>
107+ <notebook colspan="4">
108+ <page string="Authentication">
109+ <group colspan="4" col="4">
110+ <separator string="Amazon Seller Account Credentials" colspan="4"/>
111+ <field name="aws_access_key_id"/>
112+ <field name="aws_secret_access_key"/>
113+ <field name="aws_market_place_id"/>
114+ <field name="aws_merchant_id"/>
115+
116+ </group>
117+ <!--<button name="import_cat" string="Import Categories" colspan="4" type="object" />-->
118+ </page>
119+ </notebook>
120+ </sheet>
121+ </form>
122 </field>
123 </record>
124
125 <record model="ir.ui.view" id="view_patient_info_tree">
126- <field name="name">amazon.instance.tree</field>
127+ <field name="name">amazon.instance.tree</field>
128 <field name="model">amazon.instance</field>
129- <field name="type">tree</field>
130 <field name="arch" type="xml">
131- <tree string="Amazon Instance">
132- <field name="name"/>
133+ <tree string="Amazon Instance">
134+ <field name="name"/>
135 <field name="aws_access_key_id"/>
136- <field name="aws_secret_access_key"/>
137- <field name="aws_market_place_id"/>
138- <field name="aws_merchant_id"/>
139+ <field name="aws_secret_access_key"/>
140+ <field name="aws_market_place_id"/>
141+ <field name="aws_merchant_id"/>
142 </tree>
143 </field>
144 </record>
145@@ -57,27 +57,27 @@
146 <!-- Amazon Browse Nodes Form,Tree Menu Action by safan-->
147 <record id="amazon_browse_node_form_view" model="ir.ui.view">
148 <field name="name">amazon.browse.node.form</field>
149- <field name="type">form</field>
150 <field name="model">amazon.browse.node</field>
151 <field name="arch" type="xml">
152- <form string="Amazon Browse Node">
153- <group colspan="4">
154- <field name="browse_node_name" colspan="4" select="1"/>
155- <separator string="Available Browse Node Country" colspan="4"/>
156- <newline/>
157- <field name="browse_node_country" nolabel="1" colspan="4" domain="[('code','in',['US','GB','JP','IT','FR','ES','DE','CN','CA'])]"/>
158- </group>
159+ <form string="Amazon Browse Node" version="7.0">
160+ <sheet>
161+ <group colspan="4">
162+ <field name="browse_node_name" colspan="4" select="1"/>
163+ <separator string="Available Browse Node Country" colspan="4"/>
164+ <newline/>
165+ <field name="browse_node_country" nolabel="1" colspan="4" domain="[('code','in',['US','GB','JP','IT','FR','ES','DE','CN','CA'])]"/>
166+ </group>
167+ </sheet>
168 </form>
169 </field>
170 </record>
171
172 <record model="ir.ui.view" id="view_browse_node_info_tree">
173- <field name="name">amazon.browse.node.tree</field>
174+ <field name="name">amazon.browse.node.tree</field>
175 <field name="model">amazon.browse.node</field>
176- <field name="type">tree</field>
177 <field name="arch" type="xml">
178 <tree string="Amazon Browse Node">
179- <field name="browse_node_name"/>
180+ <field name="browse_node_name"/>
181 </tree>
182 </field>
183 </record>
184
185=== modified file 'category_attribute.xml'
186--- category_attribute.xml 2012-05-08 11:49:19 +0000
187+++ category_attribute.xml 2013-07-23 09:16:27 +0000
188@@ -6,27 +6,27 @@
189 <record id="view_category_attributes_form_amazon" model="ir.ui.view">
190 <field name="name">view.category.attributes.form.amazon</field>
191 <field name="model">amazon.category</field>
192- <field name="type">form</field>
193 <field name="arch" type="xml">
194- <form string="Amazon Categories">
195- <field name="name" />
196-
197- <field name="amazon_attribute_ids" colspan="8"/>
198-
199+ <form string="Amazon Categories" version="7.0">
200+ <sheet>
201+ <field name="name" />
202+ <field name="amazon_attribute_ids" colspan="8"/>
203+ </sheet>
204 </form>
205 </field>
206- <!-- For Categories Master Tree View-->
207 </record>
208+
209+ <!-- For Categories Master Tree View-->
210 <record id="view_category_attributes_tree_amazon" model="ir.ui.view">
211 <field name="name">view.category.attributes.tree_amazon</field>
212 <field name="model">amazon.category</field>
213- <field name="type">tree</field>
214 <field name="arch" type="xml">
215 <tree string="Amazon Categories">
216 <field name="name" />
217 </tree>
218 </field>
219 </record>
220+
221 <!-- Action for the categories master-->
222 <record id="action_amazon_category_master" model="ir.actions.act_window">
223 <field name="name">Amazon Categories</field>
224@@ -35,17 +35,17 @@
225 <field name="view_mode">tree,form</field>
226 <field name="view_id" ref="view_category_attributes_tree_amazon"/>
227 </record>
228+
229 <!--<menuitem id="menu_amazon_category" name="Categories" parent="menu_amazon_category_master" action="action_amazon_category_master" />-->
230 <!--for Attributes Master Form View -->
231 <record id="view_amazon_attributes_form" model="ir.ui.view">
232 <field name="name">view.amazon.attributes.form</field>
233 <field name="model">amazon.attribute</field>
234- <field name="type">form</field>
235 <field name="arch" type="xml">
236- <form string="Attributes">
237- <field name="name" colspan="2"/>
238-
239-
240+ <form string="Attributes" version="7.0">
241+ <sheet>
242+ <field name="name" colspan="2"/>
243+ </sheet>
244 </form>
245 </field>
246 </record>
247@@ -53,11 +53,9 @@
248 <record id="view_amazon_attributes_tree" model="ir.ui.view">
249 <field name="name">view.amazon.attributes.tree</field>
250 <field name="model">amazon.attribute</field>
251- <field name="type">tree</field>
252 <field name="arch" type="xml">
253 <tree string="Attributes">
254 <field name="name" />
255-
256 </tree>
257 </field>
258 </record>
259
260=== modified file 'invoice_stock.py'
261--- invoice_stock.py 2012-05-08 11:49:19 +0000
262+++ invoice_stock.py 2013-07-23 09:16:27 +0000
263@@ -100,7 +100,17 @@
264
265 class stock_partial_picking(osv.osv_memory):
266 _inherit = 'stock.partial.picking'
267-
268+
269+ def get_picking_type(self, cr, uid, picking, context=None):
270+ picking_type = picking.type
271+ for move in picking.move_lines:
272+ if picking.type == 'in' and move.product_id.cost_method == 'average':
273+ picking_type = 'in'
274+ break
275+ else:
276+ picking_type = 'out'
277+ return picking_type
278+
279 def do_partial(self, cr, uid, ids, context=None):
280 """ Makes partial moves and pickings done.
281 @param self: The object pointer.
282
283=== modified file 'partner_view.xml'
284--- partner_view.xml 2012-05-08 11:49:19 +0000
285+++ partner_view.xml 2013-07-23 09:16:27 +0000
286@@ -7,7 +7,7 @@
287 <field name="type">form</field>
288 <field name="inherit_id" ref="base.view_partner_form" />
289 <field name="arch" type="xml">
290- <xpath expr="/form/notebook" position="inside">
291+ <xpath expr="/form/sheet/notebook" position="inside">
292 <page string="Amazon Information">
293 <separator string="Amazon Shops" colspan="4" />
294 <field colspan="4" name="amazon_shop_ids" nolabel="1" widget="one2many_list">
295@@ -16,7 +16,7 @@
296 </tree>
297 </field>
298 </page>
299- </xpath>
300+ </xpath>
301 </field>
302 </record>
303 </data>
304
305=== modified file 'product_images_view.xml'
306--- product_images_view.xml 2012-05-08 11:49:19 +0000
307+++ product_images_view.xml 2013-07-23 09:16:27 +0000
308@@ -4,13 +4,14 @@
309 <record id="view_images_prod_amazon" model="ir.ui.view">
310 <field name="name">view.images.prod.amazon</field>
311 <field name="model">product.images</field>
312- <field name="type">form</field>
313- <field name="inherit_id" ref="product_images_olbs.view_product_image_form" />
314+ <field name="inherit_id" ref="product_images.view_product_image_form" />
315 <field name="arch" type="xml">
316- <xpath expr="/form/notebook" position="inside" >
317+ <xpath expr="/form/sheet/notebook" position="inside" >
318 <page string="Amazon Images">
319- <field name="amazon_url_location"/>
320- <field name="preview_amazon" widget="image"/>
321+ <group>
322+ <field name="amazon_url_location"/>
323+ <field name="preview_amazon" widget="image"/>
324+ </group>
325 </page>
326 </xpath>
327 </field>
328
329=== modified file 'product_view.xml'
330--- product_view.xml 2012-05-08 11:49:19 +0000
331+++ product_view.xml 2013-07-23 09:16:27 +0000
332@@ -4,44 +4,51 @@
333 <record id="product_amazon_form_view" model="ir.ui.view">
334 <field name="name">product.amazon.form.inherit</field>
335 <field name="model">product.product</field>
336- <field name="type">form</field>
337 <field name="inherit_id" ref="product.product_normal_form_view"/>
338 <field name="arch" type="xml">
339 <notebook position="inside">
340 <page string="Amazon Details">
341- <separator string="Amazon Details" colspan="8"/>
342- <field name="amazon_export"/>
343- <!--<field name="amazon_sku" attrs="{'readonly':[('amazon_prod_status','in',('inactive','active'))]}"/>-->
344- <newline/>
345- <field name="amazon_sku" attrs="{'readonly':[('amazon_prod_status','in',('inactive','active'))]}"/>
346- <field name="amazon_asin"/>
347- <newline/>
348- <field name="amzn_condtn" colspan="2" />
349- <field name="condition_note" colspan="4" attrs="{'invisible':[('amzn_condtn','=','')]}"/>
350- <field name="amz_type" on_change="onchange_amz_type(amz_type)"/>
351- <field name="amz_type_value" attrs="{'required':[('amz_type','in',('UPC','EAN','ASIN','ISBN'))]}"/>
352- <!--<field name="amazon_category" colspan="2" attrs="{'required':[('amazon_export','=',True)]}"/>-->
353- <field name="amazon_category" colspan="2" invisible="1"/>
354- <separator string="Submit Feed Details" colspan="8"/>
355- <field name="amazon_prod_status" invisible="1"/>
356- <field name="operation_performed" invisible="1"/>
357- <field name="submit_feed_result" colspan="4"/>
358- <separator string="Product Lookup" colspan="8"/>
359- <field name="prod_query" colspan="4"/>
360- <field name="prod_query_contextid"/>
361- <field name="amazon_instance_id"/>
362- <button name="amazon_product_lookup" string="Perform Amazon Product Search" colspan="2" type="object" />
363- <!--<button name="amazon_product_by_salesrank" string="Perform Sales Rank Operation" colspan="2" type="object" />-->
364- <!--<button name="amazon_submit_feed" string="Submit Feed" colspan="4" type="object" />-->
365- <field name="amazon_products_ids" colspan="4" nolabel="1" mode="tree">
366- <tree string="Amazon Products">
367- <field name="name" />
368- <field name="product_asin" />
369- <field name="product_category" />
370- <field name="product_id" />
371- <button name="action_process_amazon_details" string="View Amazon Product" icon="gtk-go-forward" type="object" />
372- </tree>
373- </field>
374+ <group>
375+ <separator string="Amazon Details" colspan="8"/>
376+ <group col="4" colspan="4">
377+ <field name="amazon_export"/>
378+ <!--<field name="amazon_sku" attrs="{'readonly':[('amazon_prod_status','in',('inactive','active'))]}"/>-->
379+ <newline/>
380+ <field name="amazon_sku" attrs="{'readonly':[('amazon_prod_status','in',('inactive','active'))]}"/>
381+ <field name="amazon_asin"/>
382+ <newline/>
383+ <field name="amzn_condtn" colspan="2" />
384+ <field name="condition_note" attrs="{'invisible':[('amzn_condtn','=','')]}"/>
385+ <field name="amz_type" on_change="onchange_amz_type(amz_type)"/>
386+ <field name="amz_type_value" attrs="{'required':[('amz_type','in',('UPC','EAN','ASIN','ISBN'))]}"/>
387+ <!--<field name="amazon_category" colspan="2" attrs="{'required':[('amazon_export','=',True)]}"/>-->
388+ <field name="amazon_category" colspan="2" invisible="1"/>
389+ </group>
390+ <separator string="Submit Feed Details" colspan="8"/>
391+ <group col="4" colspan="4">
392+ <field name="amazon_prod_status" invisible="1"/>
393+ <field name="operation_performed" invisible="1"/>
394+ <field name="submit_feed_result" colspan="4"/>
395+ </group>
396+ <separator string="Product Lookup" colspan="8"/>
397+ <group col="4" colspan="4">
398+ <field name="prod_query" colspan="4"/>
399+ <field name="prod_query_contextid"/>
400+ <field name="amazon_instance_id"/>
401+ <button name="amazon_product_lookup" string="Perform Amazon Product Search" colspan="2" type="object" />
402+ <!--<button name="amazon_product_by_salesrank" string="Perform Sales Rank Operation" colspan="2" type="object" />-->
403+ <!--<button name="amazon_submit_feed" string="Submit Feed" colspan="4" type="object" />-->
404+ </group>
405+ <field name="amazon_products_ids" colspan="4" nolabel="1" mode="tree">
406+ <tree string="Amazon Products">
407+ <field name="name" />
408+ <field name="product_asin" />
409+ <field name="product_category" />
410+ <field name="product_id" />
411+ <button name="action_process_amazon_details" string="View Amazon Product" icon="gtk-go-forward" type="object" />
412+ </tree>
413+ </field>
414+ </group>
415 </page>
416 </notebook>
417 </field>
418
419=== modified file 'sale_view.xml'
420--- sale_view.xml 2012-05-08 11:49:19 +0000
421+++ sale_view.xml 2013-07-23 09:16:27 +0000
422@@ -7,7 +7,6 @@
423 <field name="type">form</field>
424 <field name="inherit_id" ref="base_sale_multichannels.base_sale_multichannels_view_shop_form"/>
425 <field name="arch" type="xml">
426- <data>
427 <field name="company_id" widget='selection' groups="base.group_multi_company" position="after">
428 <field name="amazon_instance_id" attrs="{'invisible':[('amazon_shop','=',False)]}" />
429 </field>
430@@ -36,11 +35,12 @@
431 </group>
432 </page>
433 <page string="Amazon Information" attrs="{'invisible':[('amazon_shop','=',False)]}">
434- <field name="amazon_shop" />
435- <field name="auto_import_amazon" />
436+ <group>
437+ <field name="amazon_shop" />
438+ <field name="auto_import_amazon" />
439+ </group>
440 </page>
441 </xpath>
442- </data>
443 </field>
444 </record>
445 <record id="act_amazonerp_shop_form" model="ir.actions.act_window">
446@@ -56,19 +56,22 @@
447 <record id="adding_policy_view" model="ir.ui.view">
448 <field name="name">adding.policy.view</field>
449 <field name="model">sale.shop</field>
450- <field name="type">form</field>
451 <field name="inherit_id" ref="base_sale_multichannels.base_sale_multichannels_view_shop_form"/>
452 <field name="arch" type="xml">
453 <xpath expr="/form/notebook" position="inside">
454 <page string="Other Information" attrs="{'invisible':[('amazon_shop','=',False)]}">
455- <field name="amazon_picking_policy"/>
456-
457- <field name="amazon_order_policy"/>
458- <field name="amazon_invoice_quantity"/>
459+ <group>
460+ <field name="amazon_picking_policy"/>
461+
462+ <field name="amazon_order_policy"/>
463+ <field name="amazon_invoice_quantity"/>
464+ </group>
465 </page>
466 <page string="Amazon Exportable Products" attrs="{'invisible':[('amazon_shop','=',False)]}">
467+ <group>
468 <field name="amazon_exportable_product_ids" nolabel="1" colspan="4"/>
469- </page>
470+ </group>
471+ </page>
472 </xpath>
473 </field>
474 </record>
475@@ -77,7 +80,6 @@
476 <record id="view_amazon_shop_search" model="ir.ui.view">
477 <field name="name">view.amazon.shop.search</field>
478 <field name="model">sale.shop</field>
479- <field name="type">search</field>
480 <field name="arch" type="xml">
481 <search string="Sale Shop">
482 <field name="name"/>
483
484=== modified file 'security/ir.model.access.csv'
485--- security/ir.model.access.csv 2012-05-08 11:49:19 +0000
486+++ security/ir.model.access.csv 2013-07-23 09:16:27 +0000
487@@ -1,2 +1,2 @@
488-"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
489-"access_amazonerp_instance_group_sale_manager","amazonerp_instance_group_sale_manager","model_amazon_instance","base.group_sale_manager",1,1,1,1
490+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
491+access_amazonerp_instance_group_sale_manager,amazonerp_instance_group_sale_manager,model_amazon_instance,base.group_sale_manager,1,1,1,1
492\ No newline at end of file
493
494=== modified file 'wizard/create_amazon_shop.py'
495--- wizard/create_amazon_shop.py 2012-05-08 11:49:19 +0000
496+++ wizard/create_amazon_shop.py 2013-07-23 09:16:27 +0000
497@@ -14,7 +14,7 @@
498 raise osv.except_osv(_('Warning !'), _('Shop Is Already Created'))
499 return res
500 def create_amazon_shop_action(self, cr, uid, ids, context=None):
501- print"vishakha"
502+ print"::::::::::create_amazon_shop_action called::::::::"
503 # print"data_amazon_shop",data_amazon_shop
504 data_amazon_shop = self.read(cr, uid, ids, context=context)[0]
505 shop_vals = {
506@@ -41,7 +41,8 @@
507 _columns = {
508 'name': fields.char('Shop Name', size=64, required=True),
509 'warehouse_id': fields.many2one('stock.warehouse', 'Warehouse',required=True),
510- 'cust_address': fields.many2one('res.partner.address', 'Address', required=True),
511+ 'cust_address': fields.many2one('res.partner', 'Address', required=True),
512+# 'cust_address': fields.many2one('res.partner.address', 'Address', required=True),
513 'company_id': fields.many2one('res.company', 'Company', required=False),
514 'picking_policy': fields.selection([('direct', 'Partial Delivery'), ('one', 'Complete Delivery')],
515 'Packing Policy', help="""If you don't have enough stock available to deliver all at once, do you accept partial shipments or not?""",required=True),

Subscribers

People subscribed via source and target branches