dosbox-staging:jn/release-drafter-improvements

Last commit made on 2024-03-27
Get this branch:
git clone -b jn/release-drafter-improvements https://git.launchpad.net/dosbox-staging

Branch merges

Branch information

Name:
jn/release-drafter-improvements
Repository:
lp:dosbox-staging

Recent commits

2ca01cc... by John Novak <email address hidden>

Minor code style improvement

6c81b5e... by John Novak <email address hidden>

Mark backported items in the release notes draft

561df8f... by John Novak <email address hidden>

Add game compatibility category to the release notes draft

54a8ac2... by "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>

Bump fountainhead/action-wait-for-check from 1.1.0 to 1.2.0

Bumps [fountainhead/action-wait-for-check](https://github.com/fountainhead/action-wait-for-check) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/fountainhead/action-wait-for-check/releases)
- [Commits](https://github.com/fountainhead/action-wait-for-check/compare/v1.1.0...v1.2.0)

---
updated-dependencies:
- dependency-name: fountainhead/action-wait-for-check
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <email address hidden>

bd7e7dd... by japsmits <email address hidden>

Don't unnecessarily alias std::string_view

This only obfuscates the use of std::string_view.

c2eb53d... by japsmits <email address hidden>

Don't use std::string_view::data() when a zero-terminated string is expected

1923bc5... by japsmits <email address hidden>

Use std::string::c_str() instead of std::string::data()

This is done so that refactors from std::string to std::string_view get caught. The const char* returned by std::string::c_str() is guaranteed to be zero-terminated, whereas std::string_view::data() is not. This leads to undefined behavior, resulting into lingering bugs.

d221c95... by japsmits <email address hidden>

Avoid std::string_view::data()

The char* returned by std::string_view::data() is not guaranteed to point to an ascii-zero string like std::string::c_str() is. If the char* is not properly terminated, this results in undefined behaviour. Modified this code to avoid this situation.

c5c66fa... by japsmits <email address hidden>

Modernize and simplify string_utils

a7d6e11... by japsmits <email address hidden>

Use C++20 starts_with and ends_with

Remove starts_with() and ends_with() from string_utils.h and replace with the use of std::string::starts/ends_with() and std::string_view::starts/end_with().

Remove now unused unittests.