Ubuntu One Client

Code review comment for lp:~apachelogger/ubuntuone-client/kwallet-support

  1. kwallet-support
  2. Merge into trunk
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi,

Thanks a lot for putting this together!

Sadly, I must vote Disapprove.

The main reason is that ubuntu-sso will support returning the tokens via dbus, so the gnomekeyring dependency in syncdaemon will be removed as soon ubuntu-sso is ready.

review: Disapprove

« Back to merge proposal