Merge lp:~apachelogger/software-properties/python-apt-is-like into lp:software-properties

Proposed by Harald Sitter
Status: Needs review
Proposed branch: lp:~apachelogger/software-properties/python-apt-is-like
Merge into: lp:software-properties
Diff against target: 72 lines (+18/-5)
4 files modified
debian/changelog (+10/-0)
debian/control (+1/-1)
softwareproperties/SoftwareProperties.py (+4/-2)
softwareproperties/ppa.py (+3/-2)
To merge this branch: bzr merge lp:~apachelogger/software-properties/python-apt-is-like
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+310426@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

987. By Harald Sitter

* Use is_like from python-apt to determine whether or not distros
  are compatible. This act as additional constraint to the changes
  introduced in 0.96.24.2 enforcing higher accuracy on whether a
  derivate ought to be considered compatible or not.
  + Bump python-apt requirement to 1.1.0~beta5 to have is_like.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-09-23 10:47:57 +0000
3+++ debian/changelog 2016-11-09 12:40:49 +0000
4@@ -1,3 +1,13 @@
5+software-properties (0.96.24.8) UNRELEASED; urgency=medium
6+
7+ * Use is_like from python-apt to determine whether or not distros
8+ are compatible. This act as additional constraint to the changes
9+ introduced in 0.96.24.2 enforcing higher accuracy on whether a
10+ derivate ought to be considered compatible or not.
11+ + Bump python-apt requirement to 1.1.0~beta5 to have is_like.
12+
13+ -- Harald Sitter <sitter@kde.org> Wed, 09 Nov 2016 13:30:13 +0100
14+
15 software-properties (0.96.24.7) yakkety; urgency=medium
16
17 [ Dimitri John Ledkov ]
18
19=== modified file 'debian/control'
20--- debian/control 2016-09-21 11:48:24 +0000
21+++ debian/control 2016-11-09 12:40:49 +0000
22@@ -31,7 +31,7 @@
23 Section: python
24 Architecture: all
25 Depends: ${python3:Depends}, ${misc:Depends}, python3, python3-apt (>=
26- 0.6.20ubuntu16), lsb-release, iso-codes, gnupg, dirmngr
27+ 1.1.0~beta5), lsb-release, iso-codes, gnupg, dirmngr
28 Recommends: unattended-upgrades
29 Description: manage the repositories that you install software from
30 This software provides an abstraction of the used apt repositories.
31
32=== modified file 'softwareproperties/SoftwareProperties.py'
33--- softwareproperties/SoftwareProperties.py 2016-03-16 09:17:42 +0000
34+++ softwareproperties/SoftwareProperties.py 2016-11-09 12:40:49 +0000
35@@ -675,7 +675,8 @@
36 /usr/share/app-install/channels or it is a public Launchpad PPA.
37 """
38 (srcline, _fname) = shortcut.expand(
39- codename=self.distro.codename, distro=self.distro.id.lower())
40+ codename=self.distro.codename, distro=self.distro.id.lower(),
41+ distro_is_like=self.distro.is_like)
42 channel = self._is_line_in_whitelisted_channel(srcline)
43 if channel:
44 keyp = "%s/%s.key" % (self.CHANNEL_PATH, channel)
45@@ -726,7 +727,8 @@
46 """
47
48 (deb_line, file) = shortcut.expand(
49- codename=self.distro.codename, distro=self.distro.id.lower())
50+ codename=self.distro.codename, distro=self.distro.id.lower(),
51+ distro_is_like=self.distro.is_like)
52 deb_line = self.expand_http_line(deb_line)
53 debsrc_entry_type = 'deb-src' if enable_source_code else '# deb-src'
54 debsrc_line = debsrc_entry_type + deb_line[3:]
55
56=== modified file 'softwareproperties/ppa.py'
57--- softwareproperties/ppa.py 2016-09-21 20:01:50 +0000
58+++ softwareproperties/ppa.py 2016-11-09 12:40:49 +0000
59@@ -395,10 +395,11 @@
60 def info(self):
61 return self._info
62
63- def expand(self, codename, distro=None):
64+ def expand(self, codename, distro=None, distro_is_like=[]):
65 if (distro is not None
66 and distro != self._info["distribution"]
67- and not series_valid_for_distro(self._info["distribution"], codename)):
68+ and not series_valid_for_distro(self._info["distribution"], codename)
69+ and not self._info["distribution"] in distro_is_like):
70 # The requested PPA is for a foreign distribution. Guess that
71 # the user wants that distribution's current series.
72 # This only applies if the local distribution is not the same

Subscribers

People subscribed via source and target branches

to status/vote changes: