Merge lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon into lp:~gtg/gtg/old-trunk

[Roquentin]

Color the icon in the notification area when there are tasks in danger zone. Implementation of a feature described in bug #1001012. The modifications only affect the notification_area plugin. Setting a danger zone of 0 days in the preferences will reproduce the old behavior (icon is white all the time).

[lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon]

1198. By Roquentin on 2012-05-26

Use two independents views for attention and menu; this way we are able to set different filters. Use generic __connect_to_tree method

1199. By Roquentin on 2012-05-26

refactor Attention interface, store reference to indicator; use different callbacks for attention and menu trees.

[Lionel Dricot (ploum-deactivatedaccount)]

1. I enabled the tray plugin and, instead of having an icon, I had only an empty space.

2. I've set a task due for today and it raised the following:

"(gtg:4177): LIBDBUSMENU-GLIB-WARNING **: Trying to remove a child that doesn't believe we're it's parent."

review: Needs Fixing

[Roquentin (antonio-roquentin-deactivatedaccount)]

> 1. I enabled the tray plugin and, instead of having an icon, I had only an
> empty space.

It works for me on ubuntu 12.04. Which distribution are you using? In order to get the colored icon, you need to update the gtk icon theme. Temporarily I have added the colored icon to the plugin directory, its name is gtg-need-attention.svg. In my case, I copied it as

/usr/share/icons/ubuntu-mono-dark/apps/16/gtg-need-attention.svg

and then did sudo gtk-update-icon-cache. The actual path depends on the theme in use. Once things are working, I will update setup.py. Also I don't have an icon for the hicolor theme yet, sorry.

> 2. I've set a task due for today and it raised the following:
>
> "(gtg:4177): LIBDBUSMENU-GLIB-WARNING **: Trying to remove a child that
> doesn't believe we're it's parent."

This seems a bug of the plugin in trunk, it existed before my modifications. We should open a separate bug report for that.

[Roquentin (antonio-roquentin-deactivatedaccount)]

Sorry, of course the correct command to update the icon cache is (for ambiance)

sudo gtk-update-icon-cache /usr/share/icons/ubuntu-mono-dark

I am hope it fixes the problem with the empty space.

[lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon]

1200. By Roquentin on 2012-06-05

If gtg-need-attention icon is not found in theme, disable attention monitor, thus avoiding having a blank space in the panel.

1201. By Roquentin on 2012-06-05

Comply with PEP8

[Roquentin (antonio-roquentin-deactivatedaccount)]

I have filed bug #1009689 to track the problem with the warnings.

[lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon]

1202. By Roquentin on 2012-06-09

Added refresh method; refresh attention monitor when changing the danger zone in the preferences.

1203. By Roquentin on 2012-06-09

Added __init_attention method to setup attention monitor; it is called also when danger zone turns from 0 to 1 upon changing it in the preferences.

[Roquentin (antonio-roquentin-deactivatedaccount)]

I implemented a dynamic refresh of the tasks in the danger zone when changing the value of the latter in the preferences. This way one doesn't need to restart gtg to get the new danger zone to work.

In a previous revision, I changed the code so that it prints a warning if gtg-need-attention is not in the icon theme and disables the attention monitor. Lionel: could you check if it is working now?

[Roquentin (antonio-roquentin-deactivatedaccount)]

Sorry, could anyone have a look at the current version of this branch? I have fixed a few things since the last revision by Lionel.

Please also let me know what I should do to properly update the gtk theme.

[Bertrand Rousseau (bertrand-rousseau)]

Hi,

I activated your plugin, left the default settings (1-day danger zone), and defined a task as due for tomorrow. The icon color did not change. Now, I'm not familiar with this feature, so this could be caused by something else.

Also, as I can understand, your patch require to manually register a new icon. This isn't right. You have to create a custom icon them in the plugin directory and append this theme dynamically to GTG. For help, look at https://bazaar.launchpad.net/~gtg/gtg/trunk/view/head:/GTG/gtk/browser/browser.py#L142 and at the directory structure under the data/ directory in the trunk. I also recommend you search for documentation on the web. This is not really difficult, so don't panic ;-)

review: Needs Fixing (run)

[lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon]

1204. By Roquentin on 2012-07-12

Set icon_theme_path of indicator so that it can find custom icons, seems to work. Prepend data path to GTK theme search path, it finds the icon but the indicator does not load it.

1205. By Roquentin on 2012-07-12

Icon theme path

1206. By Roquentin on 2012-07-12

Refactored attention methods; update indicator status instead of icon.

1207. By Roquentin on 2012-07-12

Attempt to fix status icon

1208. By Roquentin on 2012-07-12

Dropped previous attempt.

[Roquentin (antonio-roquentin-deactivatedaccount)]

Thank you for the pointers, Bertrand. I got it to work with the application indicator (the icon is now loaded at runtime) and also cleaned up the code a bit. I hope it's ok now.

I still have troubles with the status icon, in that I don't get any icon in the system tray when I disable appindicator (same problem in trunk) and I am afraid this has to do with something in unity. So for the moment this feature is disabled when the application indicator is not available (i.e. the icon won't change).

[Bertrand Rousseau (bertrand-rousseau)]

Hi,

I tried again your code, and still couldn't see any change with the icon. Now, I'm using GNOME 3.4 and I don't know what API you're using, and if it's even supposed to work. So maybe another developer with another setup can test this particular feature here.

I have some remarks for your code:

- first, you left some text merge conflict-related strings in AUTHORS, those must be removed
- in notification_area.py, you left useless commented code on line 205-207
- I would advise you to put some padding in the plugin configuration window, right now the widgets are really tightly packed.

review: Needs Fixing (code, run)

[lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon]

1209. By Roquentin on 2012-07-13

Fixed email address in plugin authors; removed myself from AUTHORS; deleted commented lines

1210. By Roquentin on 2012-07-13

Added some padding between widgets in plugin preferences nemu

1211. By Roquentin on 2012-07-13

If there is no indicator, Attention is passed a status icon and __update_indicator() updates the status icon instead. Thus it should work even outside ubuntu now.

[Roquentin (antonio-roquentin-deactivatedaccount)]

> I tried again your code, and still couldn't see any change with the icon. Now,
> I'm using GNOME 3.4 and I don't know what API you're using, and if it's even
> supposed to work.

It should work now also when the appindicator module (ubuntu) is not available. In this case the plugin simply changes the status icon in the notification area. However, I could not get any icon to display anywhere in GNOME Shell, not even with the plugin version in trunk :-(

> - first, you left some text merge conflict-related strings in AUTHORS, those
> must be removed
> - in notification_area.py, you left useless commented code on line 205-207
> - I would advise you to put some padding in the plugin configuration window,
> right now the widgets are really tightly packed.

I fixed these issues, thank you. The preferences menu will be improved soon anyway (bug #945553).

[lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon]

1212. By Roquentin on 2012-07-14

Updated custom icon themes. Icon in hicolor now fits with the hicolor theme, it has a yellow background. Added custom icons for ambiance and radiance themes.

1213. By Roquentin on 2012-07-14

Actually it is a 22x22 icon

[Roquentin (antonio-roquentin-deactivatedaccount)]

I got the colored status icon to appear also in GNOME Shell in the system tray (bottom right corner).

So far I successfully tested the plugin using the following setups in ubuntu 12.04:

* Unity using the appindicator with both ambiance and adwaita themes

* GNOME Shell disabling the appindicator and with the adwaita theme. This should be a typical setup for distros not based on ubuntu.

When using GNOME Shell with the appindicator (default in ubuntu) it seems like the "gtg" icon is not found and nothing except "Getting Things GNOME" is displayed in the system tray. However, the colored icon is displayed when there are tasks in danger zone. This problem could be fixed for instance by adding the "gtg" icon to the plugin icons directory or using "gtg-panel" instead. I believe this problem is not related to my branch - it's there in trunk too.

[Bertrand Rousseau (bertrand-rousseau)]

I approve the code, and it works in my computer (ubuntu 12.04/GNOME 3.4.3) as you describe. It would be great however if you could fix the issue with icon not appearing when not colored as well since you seem to see how to fix it. You can always load GTG icon theme and reuse the gtg icon, it should not be necessary to copy the icon in the plugin directory. Could you do that?

review: Needs Fixing

[lp:~antonio-roquentin-deactivatedaccount/gtg/notification_colored_icon]

1214. By Roquentin on 2012-07-17

Use gtg-panel icon instead of gtg. This fixes the problem of gtg not finding the gtg icon in ubuntu 12.04/gnome 3.4 with adwaita theme

[Roquentin (antonio-roquentin-deactivatedaccount)]

Using the gtg-panel icon fixed the problem with GS under ubuntu. Tested in all other setups I have.

[Bertrand Rousseau (bertrand-rousseau)]

Ok. Approved!

review: Approve

[Bertrand Rousseau (bertrand-rousseau)]

And, btw, thanks a lot for your effort!

=== modified file 'GTG/plugins/notification-area.gtg-plugin'
--- GTG/plugins/notification-area.gtg-plugin	2012-05-23 08:55:31 +0000
+++ GTG/plugins/notification-area.gtg-plugin	2012-07-17 18:04:22 +0000
@@ -6,6 +6,6 @@
 that keeps the list of the currently workable tasks.
 To start GTG minimized,  click on the 'Configure Plugin' button 
 at the bottom of this window."""
-Authors="Paulo Cabido <[e-mail]>, Luca Invernizzi <[e-mail]>, Jono Bacon <[e-mail]>, Izidor Matušov <[e-mail]>"
+Authors="Paulo Cabido <[e-mail]>, Luca Invernizzi <[e-mail]>, Jono Bacon <[e-mail]>, Izidor Matušov <[e-mail]>, Antonio Roquentin <[e-mail]>"
 Version=0.95
 Enabled=False

=== added directory 'GTG/plugins/notification_area/data'
=== added directory 'GTG/plugins/notification_area/data/icons'
=== added directory 'GTG/plugins/notification_area/data/icons/hicolor'
=== added directory 'GTG/plugins/notification_area/data/icons/hicolor/22x22'
=== added directory 'GTG/plugins/notification_area/data/icons/hicolor/22x22/apps'
=== added file 'GTG/plugins/notification_area/data/icons/hicolor/22x22/apps/gtg_need_attention.png'
Binary files GTG/plugins/notification_area/data/icons/hicolor/22x22/apps/gtg_need_attention.png	1970-01-01 00:00:00 +0000 and GTG/plugins/notification_area/data/icons/hicolor/22x22/apps/gtg_need_attention.png	2012-07-17 18:04:22 +0000 differ
=== added directory 'GTG/plugins/notification_area/data/icons/ubuntu-mono-dark'
=== added directory 'GTG/plugins/notification_area/data/icons/ubuntu-mono-dark/22x22'
=== added directory 'GTG/plugins/notification_area/data/icons/ubuntu-mono-dark/22x22/apps'
=== added file 'GTG/plugins/notification_area/data/icons/ubuntu-mono-dark/22x22/apps/gtg_need_attention.svg'
--- GTG/plugins/notification_area/data/icons/ubuntu-mono-dark/22x22/apps/gtg_need_attention.svg	1970-01-01 00:00:00 +0000
+++ GTG/plugins/notification_area/data/icons/ubuntu-mono-dark/22x22/apps/gtg_need_attention.svg	2012-07-17 18:04:22 +0000
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+
+<svg
+   xmlns:dc="http://purl.org/dc/elements/1.1/"
+   xmlns:cc="http://creativecommons.org/ns#"
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+   xmlns:svg="http://www.w3.org/2000/svg"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   id="svg3212"
+   height="22"
+   width="22"
+   version="1.0"
+   inkscape:version="0.48.3.1 r9886"
+   sodipodi:docname="gtg-panel.svg">
+  <defs
+     id="defs8" />
+  <sodipodi:namedview
+     pagecolor="#ffffff"
+     bordercolor="#666666"
+     borderopacity="1"
+     objecttolerance="10"
+     gridtolerance="10"
+     guidetolerance="10"
+     inkscape:pageopacity="0"
+     inkscape:pageshadow="2"
+     inkscape:window-width="762"
+     inkscape:window-height="480"
+     id="namedview6"
+     showgrid="false"
+     inkscape:zoom="10.727273"
+     inkscape:cx="27.173729"
+     inkscape:cy="11"
+     inkscape:window-x="0"
+     inkscape:window-y="24"
+     inkscape:window-maximized="0"
+     inkscape:current-layer="svg3212" />
+  <metadata
+     id="metadata13">
+    <rdf:RDF>
+      <cc:Work
+         rdf:about="">
+        <dc:format>image/svg+xml</dc:format>
+        <dc:type
+           rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
+        <dc:title></dc:title>
+      </cc:Work>
+    </rdf:RDF>
+  </metadata>
+  <path
+     id="path3208"
+     d="m5 5c-1.108 0-2 0.892-2 2v10c0 1.108 0.892 2 2 2h12c1.108 0 2-0.892 2-2v-10c0-1.108-0.892-2-2-2h-12zm9.0312 2c0.05517 0.00526 0.13563 0.03589 0.1875 0.0625l1.5625 0.78125c0.2075 0.10644 0.26963 0.36771 0.15625 0.5625l-4.875 8.375c-0.085 0.149-0.267 0.239-0.436 0.219-0.0517-0.0061-0.10762-0.0063-0.15625-0.03125-0.0052-0.0024-4.25-3.3125-4.25-3.3125-0.2075-0.106-0.2697-0.367-0.1563-0.562l1.0312-1.25c0.1134-0.195 0.3863-0.263 0.5938-0.156l2.3125 1.75 3.625-6.2192c0.085-0.1461 0.241-0.2346 0.406-0.2188z"
+     style="opacity:.3" />
+  <path
+     id="rect2386"
+     d="m5 4c-1.108 0-2 0.892-2 2v10c0 1.108 0.892 2 2 2h12c1.108 0 2-0.892 2-2v-10c0-1.108-0.892-2-2-2h-12zm9.0312 2c0.05517 0.00526 0.13563 0.03589 0.1875 0.0625l1.5625 0.78125c0.2075 0.10644 0.26963 0.36771 0.15625 0.5625l-4.875 8.375c-0.085 0.149-0.267 0.239-0.436 0.219-0.0517-0.0061-0.10762-0.0063-0.15625-0.03125-0.0052-0.0024-4.25-3.3125-4.25-3.3125-0.2075-0.106-0.2697-0.367-0.1563-0.562l1.0312-1.25c0.1134-0.195 0.3863-0.263 0.5938-0.156l2.3125 1.75 3.625-6.2192c0.085-0.1461 0.241-0.2346 0.406-0.2188z"
+     style="fill:#1cbbed;fill-opacity:1" />
+</svg>

=== added directory 'GTG/plugins/notification_area/data/icons/ubuntu-mono-light'
=== added directory 'GTG/plugins/notification_area/data/icons/ubuntu-mono-light/22x22'
=== added directory 'GTG/plugins/notification_area/data/icons/ubuntu-mono-light/22x22/apps'
=== added file 'GTG/plugins/notification_area/data/icons/ubuntu-mono-light/22x22/apps/gtg_need_attention.svg'
--- GTG/plugins/notification_area/data/icons/ubuntu-mono-light/22x22/apps/gtg_need_attention.svg	1970-01-01 00:00:00 +0000
+++ GTG/plugins/notification_area/data/icons/ubuntu-mono-light/22x22/apps/gtg_need_attention.svg	2012-07-17 18:04:22 +0000
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+
+<svg
+   xmlns:dc="http://purl.org/dc/elements/1.1/"
+   xmlns:cc="http://creativecommons.org/ns#"
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+   xmlns:svg="http://www.w3.org/2000/svg"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   id="svg3212"
+   height="22"
+   width="22"
+   version="1.0"
+   inkscape:version="0.48.3.1 r9886"
+   sodipodi:docname="gtg-panel.svg">
+  <defs
+     id="defs8" />
+  <sodipodi:namedview
+     pagecolor="#ffffff"
+     bordercolor="#666666"
+     borderopacity="1"
+     objecttolerance="10"
+     gridtolerance="10"
+     guidetolerance="10"
+     inkscape:pageopacity="0"
+     inkscape:pageshadow="2"
+     inkscape:window-width="762"
+     inkscape:window-height="480"
+     id="namedview6"
+     showgrid="false"
+     inkscape:zoom="10.727273"
+     inkscape:cx="27.173729"
+     inkscape:cy="11"
+     inkscape:window-x="0"
+     inkscape:window-y="24"
+     inkscape:window-maximized="0"
+     inkscape:current-layer="svg3212" />
+  <metadata
+     id="metadata13">
+    <rdf:RDF>
+      <cc:Work
+         rdf:about="">
+        <dc:format>image/svg+xml</dc:format>
+        <dc:type
+           rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
+        <dc:title></dc:title>
+      </cc:Work>
+    </rdf:RDF>
+  </metadata>
+  <path
+     id="path3208"
+     d="m5 5c-1.108 0-2 0.892-2 2v10c0 1.108 0.892 2 2 2h12c1.108 0 2-0.892 2-2v-10c0-1.108-0.892-2-2-2h-12zm9.0312 2c0.05517 0.00526 0.13563 0.03589 0.1875 0.0625l1.5625 0.78125c0.2075 0.10644 0.26963 0.36771 0.15625 0.5625l-4.875 8.375c-0.085 0.149-0.267 0.239-0.436 0.219-0.0517-0.0061-0.10762-0.0063-0.15625-0.03125-0.0052-0.0024-4.25-3.3125-4.25-3.3125-0.2075-0.106-0.2697-0.367-0.1563-0.562l1.0312-1.25c0.1134-0.195 0.3863-0.263 0.5938-0.156l2.3125 1.75 3.625-6.2192c0.085-0.1461 0.241-0.2346 0.406-0.2188z"
+     style="opacity:.3" />
+  <path
+     id="rect2386"
+     d="m5 4c-1.108 0-2 0.892-2 2v10c0 1.108 0.892 2 2 2h12c1.108 0 2-0.892 2-2v-10c0-1.108-0.892-2-2-2h-12zm9.0312 2c0.05517 0.00526 0.13563 0.03589 0.1875 0.0625l1.5625 0.78125c0.2075 0.10644 0.26963 0.36771 0.15625 0.5625l-4.875 8.375c-0.085 0.149-0.267 0.239-0.436 0.219-0.0517-0.0061-0.10762-0.0063-0.15625-0.03125-0.0052-0.0024-4.25-3.3125-4.25-3.3125-0.2075-0.106-0.2697-0.367-0.1563-0.562l1.0312-1.25c0.1134-0.195 0.3863-0.263 0.5938-0.156l2.3125 1.75 3.625-6.2192c0.085-0.1461 0.241-0.2346 0.406-0.2188z"
+     style="fill:#1cbbed;fill-opacity:1" />
+</svg>

=== modified file 'GTG/plugins/notification_area/notification_area.py'
--- GTG/plugins/notification_area/notification_area.py	2012-05-23 08:55:31 +0000
+++ GTG/plugins/notification_area/notification_area.py	2012-07-17 18:04:22 +0000
@@ -24,7 +24,99 @@
     pass
 
 from GTG                   import _
+from GTG                   import PLUGIN_DIR
 from GTG.tools.borg        import Borg
+from GTG.tools.dates       import Date
+
+
+def _due_within(task, danger_zone):
+    """
+    Determine if a task is the danger zone.
+    Convention: a danger zone of 1 day includes tasks due today.
+    """
+    ddate = task.get_due_date()
+    if (ddate != Date.no_date()):
+        if ddate.days_left() < danger_zone:
+            return True
+    return False
+
+
+class _Attention:
+
+    """
+    Define need attention state depending on whether there
+    are tasks in danger zone.
+
+    There are two levels of attention:
+    "normal": there are no tasks in danger zone
+    "high": there is at least one task in danger zone
+
+    A task is in danger zone if the number of days left is less
+    than time span (in days) defined by danger_zone.
+    """
+
+    STATUS = {'normal': appindicator.STATUS_ACTIVE,
+              'high': appindicator.STATUS_ATTENTION}
+
+    ICON = {'normal': 'gtg-panel',
+            'high': 'gtg_need_attention'}
+
+    def __init__(self, danger_zone, indicator, tree, req):
+        self.__tree = tree
+        self.__req = req
+        self.__indicator = indicator
+        self.danger_zone = danger_zone
+
+        # Setup list of tasks in danger zone
+        """ Setup a list of tasks in danger zone, use task id """
+        self.tasks_danger = []
+        for tid in self.__tree.get_all_nodes():
+            task = self.__req.get_task(tid)
+            if _due_within(task, self.danger_zone):
+                self.tasks_danger.append(tid)
+
+        # Set initial status
+        self.__update_indicator(self.level())
+
+    def level(self):
+        """ Two states only: attention is either needed or not """
+        return 'high' if len(self.tasks_danger)>0 else 'normal'
+
+    def __update_indicator(self, new, old=None):
+        """ Reset indicator status or update upon change in status """
+        if old is None or not old == new:
+            try:
+                # This works if __indicator implements the appindicator api 
+                self.__indicator.set_status(self.STATUS[new])
+            except AttributeError:
+                # If we passed a status icon instead try this
+                self.__indicator.set_from_icon_name(self.ICON[new])
+            except:
+                raise
+
+    def update_on_task_modified(self, tid):
+        # Store current attention level
+        old_lev = self.level()
+        task = self.__req.get_task(tid)
+        if tid in self.tasks_danger:
+            if not _due_within(task, self.danger_zone):
+                self.tasks_danger.remove(tid)
+        else:
+            if _due_within(task, self.danger_zone):
+                self.tasks_danger.append(tid)
+                
+        # Update icon only if attention level has changed
+        self.__update_indicator(self.level(), old_lev)
+
+    def update_on_task_deleted(self, tid):
+        # Store current attention level
+        old_lev = self.level()
+
+        if tid in self.tasks_danger:
+            self.tasks_danger.remove(tid)
+
+        # Update icon only if attention level has changed
+        self.__update_indicator(self.level(), old_lev)
 
 
 class NotificationArea:
@@ -33,7 +125,8 @@
     to quickly access tasks.
     """
 
-    DEFAULT_PREFERENCES = {"start_minimized": False}
+    DEFAULT_PREFERENCES = {"start_minimized": False,
+                           "danger_zone": 1}
     PLUGIN_NAME = "notification_area"
     MAX_TITLE_LEN = 30
     MAX_ITEMS = 10
@@ -55,7 +148,6 @@
                                   "gtg",
                                   "indicator-messages",
                                    appindicator.CATEGORY_APPLICATION_STATUS)
-                    self._indicator.set_icon("gtg")
                 except:
                     self._indicator = None
 
@@ -76,12 +168,28 @@
         # them given the task id. Contains tuple of this format:
         # (title, key, gtk.MenuItem)
         self.__init_gtk()
-        self.__connect_to_tree()
 
-        #Load the preferences
+        # We load preferences before connecting to tree
         self.preference_dialog_init()
         self.preferences_load()
 
+        # Enable attention monitor.
+        self.__attention = None
+        self.__tree_att = self.__connect_to_tree([
+                ("node-added-inview", self.__on_task_added_att),
+                ("node-modified-inview", self.__on_task_added_att),
+                ("node-deleted-inview", self.__on_task_deleted_att),
+                ])
+        self.__tree_att.apply_filter('workview')
+        self.__init_attention()
+
+        self.__tree = self.__connect_to_tree([
+                ("node-added-inview", self.__on_task_added),
+                ("node-modified-inview", self.__on_task_added),
+                ("node-deleted-inview", self.__on_task_deleted),
+                ])
+        self.__tree.apply_filter('workview')
+
         # When no windows (browser or text editors) are shown, it tries to quit
         # With hidden browser and closing the only single text editor,
         # GTG would quit no matter what
@@ -153,18 +261,41 @@
         self.__tasks_menu = SortedLimitedMenu(self.MAX_ITEMS,
                             self.__menu, self.__menu_top_length)
 
+        # Update the icon theme
+        icon_theme = os.path.join('notification_area', 'data', 'icons')
+        abs_theme_path = os.path.join(PLUGIN_DIR[0], icon_theme)
+        theme = gtk.icon_theme_get_default()
+        theme.append_search_path(abs_theme_path)
+
         if self.__indicator:
+            self.__indicator.set_icon_theme_path(abs_theme_path)
+            self.__indicator.set_icon("gtg-panel")
+            self.__indicator.set_attention_icon("gtg_need_attention")
             self.__indicator.set_menu(self.__menu)
             self.__indicator.set_status(appindicator.STATUS_ACTIVE)
         else:
             self.status_icon = gtk.StatusIcon()
-            self.status_icon.set_from_icon_name("gtg")
+            self.status_icon.set_from_icon_name("gtg-panel")
             self.status_icon.set_tooltip("Getting Things Gnome!")
             self.status_icon.set_visible(True)
             self.status_icon.connect('activate', self.__toggle_browser)
             self.status_icon.connect('popup-menu',
                                      self.__on_icon_popup, self.__menu)
 
+    def __init_attention(self):
+        # Use two different viewtree for attention and menu
+        # This way we can filter them independently.
+        # Convention: if danger zone is <=0, disable attention
+        # Fallback: if there is no indicator we pass the status icon instead
+        if self.preferences['danger_zone'] > 0:
+            self.__attention = _Attention( \
+                self.preferences['danger_zone'],
+                self.__indicator if self.__indicator else self.status_icon,
+                self.__tree_att,
+                self.__requester)
+        else:
+            self.__attention = None
+
     def __open_task(self, widget, task_id = None):
         """
         Opens a task in the TaskEditor, if it's not currently opened.
@@ -178,21 +309,22 @@
 
         self.__view_manager.open_task(task_id, thisisnew=new_task)
 
-    def __connect_to_tree(self):
-        self.__tree = self.__requester.get_tasks_tree()
+    def __connect_to_tree(self, signal_cllbck):
+        """ Return a new view tree """
+        tree = self.__requester.get_tasks_tree()
         # Request a new view so we do not influence anybody
-        self.__tree = self.__tree.get_basetree().get_viewtree(refresh=False)
+        tree = tree.get_basetree().get_viewtree(refresh=False)
 
         self.__liblarch_callbacks = []
-        for signal, cllbck in [
-            ("node-added-inview", self.__on_task_added),
-            ("node-modified-inview", self.__on_task_added),
-            ("node-deleted-inview", self.__on_task_deleted),
-        ]:
-            cb_id = self.__tree.register_cllbck(signal, cllbck)
+        for signal, cllbck in signal_cllbck:
+            cb_id = tree.register_cllbck(signal, cllbck)
             self.__liblarch_callbacks.append((cb_id, signal))
+        return tree
 
-        self.__tree.apply_filter('workview')
+    def __on_task_added_att(self, tid, path):
+        # Update icon on modification
+        if self.__attention:
+            self.__attention.update_on_task_modified(tid)
 
     def __on_task_added(self, tid, path):
         self.__task_separator.show()
@@ -211,6 +343,11 @@
         if self.__indicator:
             self.__indicator.set_menu(self.__menu)
 
+    def __on_task_deleted_att(self, tid, path):
+        # Update icon on deletion
+        if self.__attention:
+            self.__attention.update_on_task_deleted(tid)
+
     def __on_task_deleted(self, tid, path):
         self.__tasks_menu.remove(tid)
         if self.__tasks_menu.empty():
@@ -234,10 +371,11 @@
     def preferences_load(self):
         data = self.__plugin_api.load_configuration_object(self.PLUGIN_NAME,
                                                          "preferences")
-        if not data or not isinstance(data, dict):
-            self.preferences = self.DEFAULT_PREFERENCES
-        else:
-            self.preferences = data
+        # We first load the preferences then update the dict
+        # This way new default options are recognized with old cfg files
+        self.preferences = self.DEFAULT_PREFERENCES
+        if isinstance(data, dict):
+            self.preferences.update(data)
 
     def preferences_store(self):
         self.__plugin_api.save_configuration_object(self.PLUGIN_NAME,
@@ -255,6 +393,8 @@
                     "notification_area.ui"))
         self.preferences_dialog = self.builder.get_object("preferences_dialog")
         self.chbox_minimized = self.builder.get_object("pref_chbox_minimized")
+        self.spinbutton_dangerzone = \
+            self.builder.get_object("pref_spinbutton_dangerzone")
         SIGNAL_CONNECTIONS_DIC = {
             "on_preferences_dialog_delete_event":
                 self.on_preferences_cancel,
@@ -267,6 +407,7 @@
 
     def configure_dialog(self, manager_dialog):
         self.chbox_minimized.set_active(self.preferences["start_minimized"])
+        self.spinbutton_dangerzone.set_value(self.preferences["danger_zone"])
         self.preferences_dialog.show_all()
         self.preferences_dialog.set_transient_for(manager_dialog)
 
@@ -275,6 +416,13 @@
         return True
 
     def on_preferences_ok(self, widget = None, data = None):
+        dzone = self.spinbutton_dangerzone.get_value()
+        # update danger zone only if it has changed
+        # and refresh attention monitor
+        if not dzone == self.preferences["danger_zone"]:
+            self.preferences["danger_zone"] = dzone
+            self.__init_attention()
+
         self.preferences["start_minimized"] = self.chbox_minimized.get_active()
         self.preferences_store()
         self.preferences_dialog.hide()

=== modified file 'GTG/plugins/notification_area/notification_area.ui'
--- GTG/plugins/notification_area/notification_area.ui	2012-05-23 08:55:31 +0000
+++ GTG/plugins/notification_area/notification_area.ui	2012-07-17 18:04:22 +0000
@@ -1,53 +1,116 @@
-<?xml version="1.0"?>
+<?xml version="1.0" encoding="UTF-8"?>
 <interface>
   <requires lib="gtk+" version="2.16"/>
   <!-- interface-naming-policy toplevel-contextual -->
   <object class="GtkAccelGroup" id="accelgroup1"/>
+  <object class="GtkAdjustment" id="adjustment_dangerzone">
+    <property name="upper">100</property>
+    <property name="step_increment">1</property>
+    <property name="page_increment">10</property>
+  </object>
   <object class="GtkWindow" id="preferences_dialog">
+    <property name="can_focus">False</property>
     <property name="border_width">10</property>
     <property name="window_position">center-on-parent</property>
     <property name="type_hint">dialog</property>
-    <signal name="delete_event" handler="on_preferences_dialog_delete_event"/>
+    <signal name="delete-event" handler="on_preferences_dialog_delete_event" swapped="no"/>
     <child>
       <object class="GtkVBox" id="vbox1">
         <property name="visible">True</property>
-        <property name="orientation">vertical</property>
+        <property name="can_focus">False</property>
         <child>
           <object class="GtkLabel" id="label1">
             <property name="visible">True</property>
+            <property name="can_focus">False</property>
             <property name="ypad">7</property>
             <property name="label" translatable="yes">Personalize your notification area plugin</property>
           </object>
           <packing>
+            <property name="expand">True</property>
+            <property name="fill">True</property>
             <property name="position">0</property>
           </packing>
         </child>
         <child>
           <object class="GtkVBox" id="vbox2">
             <property name="visible">True</property>
-            <property name="orientation">vertical</property>
+            <property name="can_focus">False</property>
             <child>
               <object class="GtkCheckButton" id="pref_chbox_minimized">
                 <property name="label" translatable="yes">Start gtg minimized</property>
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>
                 <property name="receives_default">False</property>
+                <property name="use_action_appearance">False</property>
                 <property name="image_position">top</property>
                 <property name="draw_indicator">True</property>
               </object>
               <packing>
+                <property name="expand">True</property>
+                <property name="fill">True</property>
                 <property name="position">0</property>
               </packing>
             </child>
           </object>
           <packing>
+            <property name="expand">True</property>
+            <property name="fill">True</property>
+            <property name="padding">5</property>
             <property name="position">1</property>
           </packing>
         </child>
         <child>
+          <object class="GtkHBox" id="hbox2">
+            <property name="visible">True</property>
+            <property name="can_focus">False</property>
+            <child>
+              <object class="GtkSpinButton" id="pref_spinbutton_dangerzone">
+                <property name="visible">True</property>
+                <property name="can_focus">True</property>
+                <property name="invisible_char">●</property>
+                <property name="width_chars">2</property>
+                <property name="primary_icon_activatable">False</property>
+                <property name="secondary_icon_activatable">False</property>
+                <property name="primary_icon_sensitive">True</property>
+                <property name="secondary_icon_sensitive">True</property>
+                <property name="adjustment">adjustment_dangerzone</property>
+                <property name="numeric">True</property>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="fill">True</property>
+                <property name="position">0</property>
+              </packing>
+            </child>
+            <child>
+              <object class="GtkLabel" id="label2">
+                <property name="visible">True</property>
+                <property name="can_focus">False</property>
+                <property name="has_tooltip">True</property>
+                <property name="tooltip_text" translatable="yes">The icon in the notification area is colored if there are tasks in the danger zone. 
+A danger zone of 0 disables icon coloring.</property>
+                <property name="xpad">4</property>
+                <property name="label" translatable="yes"> Danger zone (in days) </property>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="fill">True</property>
+                <property name="position">1</property>
+              </packing>
+            </child>
+          </object>
+          <packing>
+            <property name="expand">True</property>
+            <property name="fill">True</property>
+            <property name="padding">5</property>
+            <property name="position">2</property>
+          </packing>
+        </child>
+        <child>
           <object class="GtkHBox" id="hbox1">
             <property name="height_request">30</property>
             <property name="visible">True</property>
+            <property name="can_focus">False</property>
             <property name="spacing">50</property>
             <child>
               <object class="GtkButton" id="btn_preferences_cancel">
@@ -55,10 +118,13 @@
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>
                 <property name="receives_default">True</property>
+                <property name="use_action_appearance">False</property>
                 <property name="use_stock">True</property>
-                <signal name="clicked" handler="on_btn_preferences_cancel_clicked"/>
+                <signal name="clicked" handler="on_btn_preferences_cancel_clicked" swapped="no"/>
               </object>
               <packing>
+                <property name="expand">True</property>
+                <property name="fill">True</property>
                 <property name="position">0</property>
               </packing>
             </child>
@@ -68,16 +134,22 @@
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>
                 <property name="receives_default">True</property>
+                <property name="use_action_appearance">False</property>
                 <property name="use_stock">True</property>
-                <signal name="clicked" handler="on_btn_preferences_ok_clicked"/>
+                <signal name="clicked" handler="on_btn_preferences_ok_clicked" swapped="no"/>
               </object>
               <packing>
+                <property name="expand">True</property>
+                <property name="fill">True</property>
                 <property name="position">1</property>
               </packing>
             </child>
           </object>
           <packing>
-            <property name="position">2</property>
+            <property name="expand">True</property>
+            <property name="fill">True</property>
+            <property name="padding">5</property>
+            <property name="position">3</property>
           </packing>
         </child>
       </object>