Merge ~anthonywong/ubuntu/+source/update-manager:i18n-2 into ubuntu/+source/update-manager:ubuntu/devel

Proposed by Anthony Wong
Status: Needs review
Proposed branch: ~anthonywong/ubuntu/+source/update-manager:i18n-2
Merge into: ubuntu/+source/update-manager:ubuntu/devel
Diff against target: 111 lines (+62/-0) (has conflicts)
3 files modified
.bzrignore (+11/-0)
UpdateManager/UpdatesAvailable.py (+42/-0)
po/update-manager.pot (+9/-0)
Conflict in UpdateManager/UpdatesAvailable.py
Conflict in po/update-manager.pot
Reviewer Review Type Date Requested Status
git-ubuntu import Pending
Todd Pending
Julian Andres Klode Pending
Review via email: mp+448264@code.launchpad.net

This proposal supersedes a proposal from 2022-01-01.

Commit message

Resubmit against main branch

Description of the change

The "out of disk space" error message could be hard to be localized since parameters can't be reordered.

To post a comment you must log in.
Revision history for this message
Todd (todstephens80) wrote : Posted in a previous version of this proposal

I see since parameters can't be reordered.

Revision history for this message
Todd (todstephens80) wrote : Posted in a previous version of this proposal

since parameters can't be reordered.

review: Approve
Revision history for this message
Julian Andres Klode (juliank) wrote : Posted in a previous version of this proposal

Please resubmit against https://code.launchpad.net/~ubuntu-core-dev/update-manager/+git/update-manager/+ref/main if this is still an issue so it can be queued with changes for a later release.

review: Needs Resubmitting

Unmerged commits

5354369... by Anthony Wong

Better i18n for the "out of disk space" error message.

Signed-off-by: Anthony Wong <email address hidden>

30b96e6... by Brian Murray

releasing package update-manager version 1:23.10.1

cf5425f... by Brian Murray

When displaying updates also include the quantity of updates in each group. Thanks to Robert Ancell for the patch.

6a3278c... by Brian Murray

Cherry pick a patch to show a count of updates

This was in a bzr merge proposal from Robert Ancell

65932d5... by Benjamin Drung

Release update-manager 1:23.04.2

Signed-off-by: Benjamin Drung <email address hidden>

a99745d... by Benjamin Drung

Run nosetests in verbose mode

Signed-off-by: Benjamin Drung <email address hidden>

7d7dfde... by Grant Orndorff

pro: fix field name of package name

faa233e... by Grant Orndorff

pro: fallback to no pro updates if pro api errors

LP: #2015113
LP: #2015286

7c8c983... by Benjamin Drung

Update Vcs-* links to git

Signed-off-by: Benjamin Drung <email address hidden>

921b9c0... by Benjamin Drung

Release update-manager 1:23.04.1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.bzrignore b/.bzrignore
2new file mode 100644
3index 0000000..981119f
4--- /dev/null
5+++ b/.bzrignore
6@@ -0,0 +1,11 @@
7+__pycache__
8+debian/*.debhelper*
9+debian/*.substvars
10+debian/files
11+debian/python-update-manager
12+debian/python3-update-manager
13+debian/tmp
14+debian/update-manager
15+debian/update-manager-core
16+debian/update-manager-kde
17+debian/update-manager-text
18diff --git a/UpdateManager/UpdatesAvailable.py b/UpdateManager/UpdatesAvailable.py
19index e081e1f..1bc15be 100644
20--- a/UpdateManager/UpdatesAvailable.py
21+++ b/UpdateManager/UpdatesAvailable.py
22@@ -897,8 +897,13 @@ class UpdatesAvailable(InternalDialog):
23 # print("on_button_install_clicked")
24 err_sum = _("Not enough free disk space")
25 err_msg = _(
26+<<<<<<< UpdateManager/UpdatesAvailable.py
27 "The upgrade needs a total of %s free space on disk '%s'. "
28 "Please free at least an additional %s of disk space on '%s'. %s"
29+=======
30+ "The upgrade needs a total of %(size_total)s free space on disk '%(dir)s'. "
31+ "Please free at least an additional %(size_needed)s of disk space on '%(dir)s'. %(remedy)s"
32+>>>>>>> UpdateManager/UpdatesAvailable.py
33 )
34 # specific ways to resolve lack of free space
35 remedy_archivedir = _(
36@@ -927,6 +932,7 @@ class UpdatesAvailable(InternalDialog):
37 if err_long != "":
38 err_long += " "
39 if req.dir == archivedir:
40+<<<<<<< UpdateManager/UpdatesAvailable.py
41 err_long += err_msg % (
42 req.size_total,
43 req.dir,
44@@ -966,6 +972,42 @@ class UpdatesAvailable(InternalDialog):
45 req.dir,
46 remedy_usr,
47 )
48+=======
49+ err_long += err_msg % {
50+ "size_total": req.size_total,
51+ "dir": req.dir,
52+ "size_needed": req.size_needed,
53+ "remedy": remedy_archivedir,
54+ }
55+ elif req.dir == "/boot":
56+ err_long += err_msg % {
57+ "size_total": req.size_total,
58+ "dir": req.dir,
59+ "size_needed": req.size_needed,
60+ "remedy": remedy_boot,
61+ }
62+ elif req.dir == "/":
63+ err_long += err_msg % {
64+ "size_total": req.size_total,
65+ "dir": req.dir,
66+ "size_needed": req.size_needed,
67+ "remedy": remedy_root,
68+ }
69+ elif req.dir == "/tmp":
70+ err_long += err_msg % {
71+ "size_total": req.size_total,
72+ "dir": req.dir,
73+ "size_needed": req.size_needed,
74+ "remedy": remedy_tmp,
75+ }
76+ elif req.dir == "/usr":
77+ err_long += err_msg % {
78+ "size_total": req.size_total,
79+ "dir": req.dir,
80+ "size_needed": req.size_needed,
81+ "remedy": remedy_usr,
82+ }
83+>>>>>>> UpdateManager/UpdatesAvailable.py
84 self.window_main.start_error(False, err_sum, err_long)
85 return
86 except SystemError:
87diff --git a/po/update-manager.pot b/po/update-manager.pot
88index a3d5c06..5c02c2a 100644
89--- a/po/update-manager.pot
90+++ b/po/update-manager.pot
91@@ -336,11 +336,20 @@ msgstr ""
92 msgid "Not enough free disk space"
93 msgstr ""
94
95+<<<<<<< po/update-manager.pot
96 #: ../UpdateManager/UpdatesAvailable.py:831
97 #, python-format
98 msgid ""
99 "The upgrade needs a total of %s free space on disk '%s'. Please free at "
100 "least an additional %s of disk space on '%s'. %s"
101+=======
102+#: ../UpdateManager/UpdatesAvailable.py:900
103+#, python-format
104+msgid ""
105++"The upgrade needs a total of %(size_total)s free space on disk '%(dir)s'. "
106++"Please free at least an additional %(size_needed)s of disk space on "
107++"'%(dir)s'. %(remedy)s"
108+>>>>>>> po/update-manager.pot
109 msgstr ""
110
111 #. specific ways to resolve lack of free space

Subscribers

People subscribed via source and target branches