Code review comment for ~anthonywong/ubuntu/+source/u-boot:ubuntu/bionic-proposed

> Ok, this generally looks good, especially in the case where both we and Debian
> do not build the nitrogen6q2g target by default - so we have a bit more
> 'freedom' here, as we have realistically no users.
>
> What I would like to know before proceeding is how upstreamable this change
> is. I see the change of default from SPI flash to FAT seems a bit like
> something Ubuntu-specific (especially the CONFIG_ENV_FAT_FILE="uboot.env"
> part, which seems to be partially what we were doing for our old pi core
> images). I suppose it doesn't make sense to push it upstream? Or does it?
These patches are required for Ubuntu Core, which makes them specific to our OS. The chances of these patches being accepted upstream are slim.
Further, if we are to build gadget snaps from u-boot deb's from LP, should we have a branch or flavour for u-boot package in each series (Xenial, Bionic, etc) where these common patches which add support for Ubuntu Core can be applied without affecting upstream imports?

Comments/Suggestions?