Merge lp:~anj/epics-base/udf-severity into lp:~epics-core/epics-base/3.15
Status: | Merged |
---|---|
Merged at revision: | 12428 |
Proposed branch: | lp:~anj/epics-base/udf-severity |
Merge into: | lp:~epics-core/epics-base/3.15 |
Diff against target: |
297 lines (+39/-19) 20 files modified
documentation/RELEASE_NOTES.html (+9/-0) src/ioc/db/dbCommon.dbd (+7/-1) src/ioc/misc/iocInit.c (+5/-0) src/std/dev/devTimestamp.c (+1/-1) src/std/rec/aiRecord.c (+1/-1) src/std/rec/aoRecord.c (+1/-1) src/std/rec/biRecord.c (+1/-1) src/std/rec/boRecord.c (+1/-1) src/std/rec/calcRecord.c (+1/-1) src/std/rec/calcoutRecord.c (+2/-2) src/std/rec/dfanoutRecord.c (+1/-1) src/std/rec/longinRecord.c (+1/-1) src/std/rec/longoutRecord.c (+1/-1) src/std/rec/mbbiRecord.c (+1/-1) src/std/rec/mbboDirectRecord.c (+1/-1) src/std/rec/mbboRecord.c (+1/-1) src/std/rec/selRecord.c (+1/-1) src/std/rec/stringoutRecord.c (+1/-1) src/std/rec/subArrayRecord.c (+1/-1) src/std/rec/subRecord.c (+1/-1) |
To merge this branch: | bzr merge lp:~anj/epics-base/udf-severity |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
EPICS Core Developers | Pending | ||
Review via email: mp+139024@code.launchpad.net |
Description of the change
This branch adds a new alarm severity field UDFS to dbCommon, which is used as the alarm severity whenever a record is put in an undefined state (UDF=TRUE). It defaults to INVALID, so there should be no change to the default behavior of existing databases. Out-of-tree record types will need upgrading to implement this properly, usually in the checkAlarms() routine; the base record types that check UDF have been modified in this branch.
I'm not sure whether doing this is a good idea or not; I suspect it would be very useful in some cases, but there could be bad effects on databases that have been designed to use IVOA and someone who doesn't understand the design changes UDFS on some critical record(s). Discussion encouraged.
Am Montag, 10. Dezember 2012, 17:28:16 schrieb Andrew Johnson: /code.launchpad .net/~anj/ epics-base/ udf-severity/ +merge/ 139024
> Andrew Johnson has proposed merging lp:~anj/epics-base/udf-severity into
> lp:epics-base.
>
> Requested reviews:
> EPICS Core Developers (epics-core)
>
> For more details, see:
> https:/
>
> This branch adds a new alarm severity field UDFS to dbCommon, which is used
> as the alarm severity whenever a record is put in an undefined state
> (UDF=TRUE). It defaults to INVALID, so there should be no change to the
> default behavior of existing databases. Out-of-tree record types will
> need upgrading to implement this properly, usually in the checkAlarms()
> routine; the base record types that check UDF have been modified in this
> branch.
I appreciate that you communicate this change before merging, even though I am
clearly in favour.
> I'm not sure whether doing this is a good idea or not; I suspect it would
> be very useful in some cases,
Indeed.
> but there could be bad effects on databases
> that have been designed to use IVOA and someone who doesn't understand the
> design changes UDFS on some critical record(s). Discussion encouraged.
Make the change clear and prominent in the release notes. Users who upgrade
their base should have at least one person on site who knows something about
EPICS base and what this change might impact.
Cheers
--
Ben Franksen
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
_______ _______ _______ _______ ____
Helmholtz-Zentrum Berlin für Materialien und Energie GmbH
Mitglied der Hermann von Helmholtz- Gemeinschaft Deutscher Forschungszentren e.V.
Aufsichtsrat: Vorsitzender Prof. Dr. Dr. h.c. mult. Joachim Treusch, stv. Vorsitzende Dr. Beatrix Vierkorn-Rudolph
Geschäftsführung: Prof. Dr. Anke Rita Kaysser-Pyzalla, Thomas Frederking
Sitz Berlin, AG Charlottenburg, 89 HRB 5583
Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin
http:// www.helmholtz- berlin. de