Merge lp:~angeloc/ubuntu-accomplishments-daemon/fix-for-typo into lp:ubuntu-accomplishments-daemon

[Angelo Compagnucci]

Fixed typo in pyhton format string

[lp:~angeloc/ubuntu-accomplishments-daemon/fix-for-typo]

39. By Angelo Compagnucci on 2012-05-03

modified:
  accomplishments/daemon/api.py
   Fixed various typo in python format string

[James Tatum (jtatum)]

Good finds!

review: Approve

[Rafał Cieślak (rafalcieslak256)]

Thanks Angelo for finding these, and apologies for the time it took to review them, despite their simplicity.
It turned out that most of these is not anymore present in the code because the daemon has been significantly rewritten. This caused this branch to be not mergable without serious conflicts... However, I have applied your fixes manually whereever it was appropriate, which is why I'll mark it as merged.
Thanks again, nice job!

=== modified file 'accomplishments/daemon/api.py'
--- accomplishments/daemon/api.py	2012-04-28 21:57:30 +0000
+++ accomplishments/daemon/api.py	2012-05-03 09:27:22 +0000
@@ -399,7 +399,7 @@
 
         log.msg(
             "------------------- Ubuntu Accomplishments Daemon Log - %s "
-            "-------------------", str(datetime.datetime.now()))
+            "-------------------" % str(datetime.datetime.now()))
 
         self._load_config_file()
 
@@ -718,7 +718,7 @@
     def get_config_value(self, section, item):
         """Return a configuration value from the .accomplishments file"""
         log.msg(
-            "Returning configuration values for: %s, %s", section, item)
+            "Returning configuration values for: %s, %s" % (section, item))
         homedir = os.getenv("HOME")
         config = ConfigParser.RawConfigParser()
         cfile = self.dir_config + "/.accomplishments"
@@ -737,7 +737,7 @@
     def write_config_file_item(self, section, item, value):
         """Set a configuration value in the .accomplishments file"""
         log.msg(
-            "Set configuration file value in '%s': %s = %s", section, item,
+            "Set configuration file value in '%s': %s = %s" % (section, item),
             value)
         homedir = os.getenv("HOME")
         config = ConfigParser.RawConfigParser()
@@ -792,7 +792,7 @@
             if app in l:
                 lang = l[app]
         log.msg(
-            "Accomplishing something: %s, %s", app, accomplishment_name)
+            "Accomplishing something: %s, %s" % (app, accomplishment_name))
         accom_file = os.path.join(self.accomplishments_path, app, lang,
             "%s.accomplishment" % accomplishment_name)
         try:
@@ -1227,7 +1227,7 @@
            
         # XXX this should be removed as we are using write_extra_information_file
         log.msg(
-            "Creating Extra Information file: %s, %s, %s", app, item, data)
+            "Creating Extra Information file: %s, %s, %s" % (app, item, data))
         extrainfodir = os.path.join(self.trophies_path, ".extrainformation/")
 
         if not os.path.isdir(extrainfodir):
@@ -1243,7 +1243,7 @@
     def write_extra_information_file(self, app, item, data):
 
         log.msg(
-            "Saving Extra Information file: %s, %s, %s", app, item, data)
+            "Saving Extra Information file: %s, %s, %s" % (app, item, data))
         extrainfodir = os.path.join(self.trophies_path, ".extrainformation/")
 
         if not os.path.isdir(extrainfodir):