Merge lp:~andrius-preimantas/server-env-tools/mass_editing into lp:~serpentcs/server-env-tools/mass_editing_7.0

Proposed by Andrius Preimantas @ hbee
Status: Rejected
Rejected by: Serpent Consulting Services
Proposed branch: lp:~andrius-preimantas/server-env-tools/mass_editing
Merge into: lp:~serpentcs/server-env-tools/mass_editing_7.0
Diff against target: 19 lines (+3/-0)
2 files modified
mass_editing/__openerp__.py (+1/-0)
mass_editing/security/ir.model.access.csv (+2/-0)
To merge this branch: bzr merge lp:~andrius-preimantas/server-env-tools/mass_editing
Reviewer Review Type Date Requested Status
Serpent Consulting Services Disapprove
Guewen Baconnier @ Camptocamp (community) Approve
Alexandre Fayolle - camptocamp (community) code review, no test Approve
Review via email: mp+151456@code.launchpad.net

Description of the change

Added access rules

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Note that this merge proposal should be targetted on lp:server-env-tools with the prerequisite branch lp:~serpent-consulting-services/server-env-tools/mass_editing_7.0

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

For the record, revision 37 of https://code.launchpad.net/~serpent-consulting-services/server-env-tools/mass_editing_7.0 adds (broader) access rules on the configuration model. I'd rather restrict employee access to reading like this branch proposes. Maybe you want to merge with the target branch and change accordingly?

Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :
review: Disapprove

Unmerged revisions

36. By Andrius Preimantas @ hbee

[FIX] Added access rule for employee group

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mass_editing/__openerp__.py'
2--- mass_editing/__openerp__.py 2013-02-14 20:31:22 +0000
3+++ mass_editing/__openerp__.py 2013-03-04 10:42:24 +0000
4@@ -33,6 +33,7 @@
5 'depends': ['base'],
6 'data': [
7 'mass_editing_view.xml',
8+ 'security/ir.model.access.csv',
9 ],
10 'installable': True,
11 'application': True,
12
13=== added directory 'mass_editing/security'
14=== added file 'mass_editing/security/ir.model.access.csv'
15--- mass_editing/security/ir.model.access.csv 1970-01-01 00:00:00 +0000
16+++ mass_editing/security/ir.model.access.csv 2013-03-04 10:42:24 +0000
17@@ -0,0 +1,2 @@
18+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
19+"access_mass_object_employee","mass.object.employee","model_mass_object","base.group_user",1,0,0,0

Subscribers

People subscribed via source and target branches