Merge lp:~andrewsomething/unity-scope-click/lp1234211 into lp:unity-scope-click

Proposed by Andrew Starr-Bochicchio
Status: Superseded
Proposed branch: lp:~andrewsomething/unity-scope-click/lp1234211
Merge into: lp:unity-scope-click
Diff against target: 46 lines (+8/-8)
2 files modified
scope/click/preview.cpp (+4/-4)
src/click-scope.vala (+4/-4)
To merge this branch: bzr merge lp:~andrewsomething/unity-scope-click/lp1234211
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Needs Fixing
Review via email: mp+207723@code.launchpad.net

Commit message

Correct language in 'uninstall confirmation' dialog.

Description of the change

This has been bothering me for some time. I'd assumed that since there
is an open design task, that someone was going to weigh in authoritatively.
Since that still hasn't happened, here's my take on what the wording should
be.

At least on a Nexus 4, when you open the uninstall dialog the longer
message is off screen. So I replaced "Confirmation" with "Uninstall"
That's the important piece of information that the user should see.

I changed the buttons to OK/Cancel. I also kept the word "uninstall"
rather than using "remove." I think that "uninstall" is no longer
technical jargon, and we want to be clear we are uninstalling the app,
not just removing it from that particular menu.

To post a comment you must log in.
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Hi Andrew, thanks for working on this.

I like the wording changes in your branch, but I disagree with using OK & Cancel.
All UX guidelines nowadays frown upon using that, and instead suggest using verbs for action buttons like these.

More details can be found here:
http://ux.stackexchange.com/questions/9946/should-i-use-yes-no-or-ok-cancel-on-my-message-box
http://uxmovement.com/buttons/why-the-ok-button-is-no-longer-okay/

review: Needs Fixing
Revision history for this message
dobey (dobey) wrote :

We need design input/approval, but my suggestion would be to just get rid of the "confirm" page completely. Also, "remove" is better wording to use than "uninstall" in these cases. But it's unlikely that someone will accidentally uninstall an app, and most apps are small enough that recovery by re-installing is a minor annoyance if one does make such a mistake.

The "remove all its information" bit is also a bit scary and off-putting, and not quite true.

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

What's the most we can do without design feedback? "Uninstall this app will" and "Yes Uninstall" are just incorrect grammar. Can we at least change them to "Uninstalling this app will" and "Yes, Uninstall" ?

Unmerged revisions

170. By Andrew Starr-Bochicchio

Correct language in 'uninstall confirmation' dialog.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scope/click/preview.cpp'
--- scope/click/preview.cpp 2014-02-21 08:29:03 +0000
+++ scope/click/preview.cpp 2014-02-21 18:27:30 +0000
@@ -174,20 +174,20 @@
174 scopes::PreviewWidgetList widgets;174 scopes::PreviewWidgetList widgets;
175175
176 scopes::PreviewWidget header("hdr", "header");176 scopes::PreviewWidget header("hdr", "header");
177 header.add_attribute("title", scopes::Variant("Confirmation"));177 header.add_attribute("title", scopes::Variant("Uninstall"));
178 header.add_attribute("subtitle",178 header.add_attribute("subtitle",
179 scopes::Variant("Uninstall this app will delete all the related information. Are you sure you want to uninstall?"));179 scopes::Variant("Uninstalling this application will delete all of its information. Do you want to continue?"));
180 widgets.push_back(header);180 widgets.push_back(header);
181181
182 scopes::PreviewWidget buttons("buttons", "actions");182 scopes::PreviewWidget buttons("buttons", "actions");
183 scopes::VariantBuilder builder;183 scopes::VariantBuilder builder;
184 builder.add_tuple({184 builder.add_tuple({
185 {"id", scopes::Variant(click::Preview::Actions::CLOSE_PREVIEW)},185 {"id", scopes::Variant(click::Preview::Actions::CLOSE_PREVIEW)},
186 {"label", scopes::Variant("Not anymore")}186 {"label", scopes::Variant("Cancel")}
187 });187 });
188 builder.add_tuple({188 builder.add_tuple({
189 {"id", scopes::Variant(click::Preview::Actions::CONFIRM_UNINSTALL)},189 {"id", scopes::Variant(click::Preview::Actions::CONFIRM_UNINSTALL)},
190 {"label", scopes::Variant("Yes Uninstall")}190 {"label", scopes::Variant("OK")}
191 });191 });
192 buttons.add_attribute("actions", builder.end());192 buttons.add_attribute("actions", builder.end());
193 widgets.push_back(buttons);193 widgets.push_back(buttons);
194194
=== modified file 'src/click-scope.vala'
--- src/click-scope.vala 2014-01-17 18:48:52 +0000
+++ src/click-scope.vala 2014-02-21 18:27:30 +0000
@@ -109,10 +109,10 @@
109 }109 }
110110
111 Unity.Preview build_uninstall_confirmation_preview () {111 Unity.Preview build_uninstall_confirmation_preview () {
112 var message = "Uninstall this app will delete all the related information. Are you sure you want to uninstall?";112 var message = "Uninstalling this application will delete all of its information. Do you want to continue?";
113 var preview = new Unity.GenericPreview("Confirmation", message, null);113 var preview = new Unity.GenericPreview("Uninstall", message, null);
114 preview.add_action (new Unity.PreviewAction (ACTION_CLOSE_PREVIEW, ("Not anymore"), null));114 preview.add_action (new Unity.PreviewAction (ACTION_CLOSE_PREVIEW, ("Cancel"), null));
115 preview.add_action (new Unity.PreviewAction (ACTION_CONFIRM_UNINSTALL, ("Yes Uninstall"), null));115 preview.add_action (new Unity.PreviewAction (ACTION_CONFIRM_UNINSTALL, ("OK"), null));
116 return preview;116 return preview;
117 }117 }
118118

Subscribers

People subscribed via source and target branches