Merge lp:~andrewsomething/unity-scope-click/lp1234211 into lp:unity-scope-click

[Andrew Starr-Bochicchio]

Correct language in 'uninstall confirmation' dialog.

This has been bothering me for some time. I'd assumed that since there
is an open design task, that someone was going to weigh in authoritatively.
Since that still hasn't happened, here's my take on what the wording should
be.

At least on a Nexus 4, when you open the uninstall dialog the longer
message is off screen. So I replaced "Confirmation" with "Uninstall"
That's the important piece of information that the user should see.

I changed the buttons to OK/Cancel. I also kept the word "uninstall"
rather than using "remove." I think that "uninstall" is no longer
technical jargon, and we want to be clear we are uninstalling the app,
not just removing it from that particular menu.

[Alejandro J. Cura (alecu)]

Hi Andrew, thanks for working on this.

I like the wording changes in your branch, but I disagree with using OK & Cancel.
All UX guidelines nowadays frown upon using that, and instead suggest using verbs for action buttons like these.

More details can be found here:
http://ux.stackexchange.com/questions/9946/should-i-use-yes-no-or-ok-cancel-on-my-message-box
http://uxmovement.com/buttons/why-the-ok-button-is-no-longer-okay/

review: Needs Fixing

[dobey (dobey)]

We need design input/approval, but my suggestion would be to just get rid of the "confirm" page completely. Also, "remove" is better wording to use than "uninstall" in these cases. But it's unlikely that someone will accidentally uninstall an app, and most apps are small enough that recovery by re-installing is a minor annoyance if one does make such a mistake.

The "remove all its information" bit is also a bit scary and off-putting, and not quite true.

[Andrew Starr-Bochicchio (andrewsomething)]

What's the most we can do without design feedback? "Uninstall this app will" and "Yes Uninstall" are just incorrect grammar. Can we at least change them to "Uninstalling this app will" and "Yes, Uninstall" ?

Unmerged revisions

170. By Andrew Starr-Bochicchio on 2014-02-21

Correct language in 'uninstall confirmation' dialog.

=== modified file 'scope/click/preview.cpp'
--- scope/click/preview.cpp	2014-02-21 08:29:03 +0000
+++ scope/click/preview.cpp	2014-02-21 18:27:30 +0000
@@ -174,20 +174,20 @@
     scopes::PreviewWidgetList widgets;
 
     scopes::PreviewWidget header("hdr", "header");
-    header.add_attribute("title", scopes::Variant("Confirmation"));
+    header.add_attribute("title", scopes::Variant("Uninstall"));
     header.add_attribute("subtitle",
-                         scopes::Variant("Uninstall this app will delete all the related information. Are you sure you want to uninstall?"));
+                         scopes::Variant("Uninstalling this application will delete all of its information. Do you want to continue?"));
     widgets.push_back(header);
 
     scopes::PreviewWidget buttons("buttons", "actions");
     scopes::VariantBuilder builder;
     builder.add_tuple({
        {"id", scopes::Variant(click::Preview::Actions::CLOSE_PREVIEW)},
-       {"label", scopes::Variant("Not anymore")}
+       {"label", scopes::Variant("Cancel")}
     });
     builder.add_tuple({
        {"id", scopes::Variant(click::Preview::Actions::CONFIRM_UNINSTALL)},
-       {"label", scopes::Variant("Yes Uninstall")}
+       {"label", scopes::Variant("OK")}
     });
     buttons.add_attribute("actions", builder.end());
     widgets.push_back(buttons);

=== modified file 'src/click-scope.vala'
--- src/click-scope.vala	2014-01-17 18:48:52 +0000
+++ src/click-scope.vala	2014-02-21 18:27:30 +0000
@@ -109,10 +109,10 @@
   }
 
   Unity.Preview build_uninstall_confirmation_preview () {
-    var message = "Uninstall this app will delete all the related information. Are you sure you want to uninstall?";
-    var preview = new Unity.GenericPreview("Confirmation", message, null);
-    preview.add_action (new Unity.PreviewAction (ACTION_CLOSE_PREVIEW, ("Not anymore"), null));
-    preview.add_action (new Unity.PreviewAction (ACTION_CONFIRM_UNINSTALL, ("Yes Uninstall"), null));
+    var message = "Uninstalling this application will delete all of its information. Do you want to continue?";
+    var preview = new Unity.GenericPreview("Uninstall", message, null);
+    preview.add_action (new Unity.PreviewAction (ACTION_CLOSE_PREVIEW, ("Cancel"), null));
+    preview.add_action (new Unity.PreviewAction (ACTION_CONFIRM_UNINSTALL, ("OK"), null));
     return preview;
   }