Code review comment for lp:~andrewsomething/ubuntu/quantal/fonts-unfonts-core/font-config-conf-fix

Dimitri John Ledkov (xnox) wrote :

Actually this will fail.

Previously it was: OR between each string. (match in any of these cases)
Now you changed it to: AND between each string (match in all of these cases simultaneously, i.e. never)

You need to copy past the match tag around each test as well.

See:
https://bugs.launchpad.net/ubuntu/+source/fonts-unfonts-core/+bug/1034928/comments/23

review: Resubmit

« Back to merge proposal